Don't nick SIGTERM

[nilstoedtmann]

bacpypes.core sets bacpypes.core.stop() as signal handler for SIGTERM. That stops any application that imports bacpypes from catching SIGTERM itself for a graceful shutdown.

We are happy to call bacpypes.core.stop() in our SIGTERM handler.

Or maybe make it configurable.

[JoelBender]

Humm... how about sigterm and sigusr1 as new keyword parameters to the run function with the existing functions as defaults?

def run(spin=SPIN, sigterm=stop, sigusr1=print_stack):
    ...
    if (sigterm is not None) and hasattr(signal, 'SIGTERM'):
        signal.signal(signal.SIGTERM, sigterm)
    if (sigusr1 is not None) and hasattr(signal, 'SIGUSR1'):
        signal.signal(SIGUSR1, sigusr1)
    ...

Your applications could pass in None. I'm not sure how many applications rely on the current behavior, apart from mine. I would like to hear from more users.

[nilstoedtmann]

👍 That should work for us. Good not to set the handler at import time.

[JoelBender]

Ok, this is now sitting in the 112-dont-nick-sigterm branch.

[nilstoedtmann]

BTW you could also check whether the signal in question has already a handler assigned. See e.g. http://stackoverflow.com/a/12018294 .
I don't have a preference, just saying.

[nilstoedtmann]

Either way I hope this will find its way into the next release :)

[JoelBender]

I missed this with 0.15.1 out of git branch sync confusion with the different platforms I'm using for testing, but it will be in 0.15.2 shortly.

[JoelBender]

This has introduced a bug, see #119 and continue the discussion...