Transparency support for D3D swap chain #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
force-pushed
the
ivan.matkov/transparency-support-d3d
branch
from
bdf8985 to
6dee5e9
Compare
eymar
approved these changes
Dec 7, 2023
igordmn
requested changes
Dec 12, 2023
igordmn
reviewed
Dec 12, 2023
As was always before, and for all other renderer API on Windows. I wrote comment with explanation here: #915: ComposeWindowDelegate.desktop.kt R112-R120 /*
* Windows makes clicks on transparent pixels fall through, but it doesn't work
* with GPU accelerated rendering since this check requires having access to pixels from CPU.My position here is to DROP |
igordmn
approved these changes
Dec 12, 2023
MatkovIvan
added a commit
to JetBrains/compose-multiplatform-core
that referenced
this pull request
Dec 15, 2023
## Proposed Changes
- Adopt an approach that we're using for iOS - using custom blending to
respect clip/shape modifiers and overlapped drawings.
- Fix bounds in window calculation - it should work properly inside
scaled content now.
## Testing
The new behavior is under a feature flag, so you can test it by setting
system property:
```kt
System.setProperty("compose.interop.blending", "true")
```
Currently it supports Metal (macOS), Direct3D (Windows) (requires
JetBrains/skiko#837), and off-screen rendering
(might be enable by another feature flag:
`compose.swing.render.on.graphics`)
### Clipping
```kt
SwingPanel(
modifier = Modifier.clip(RoundedCornerShape(6.dp))
...
)
```
<img width="262" alt="image"
src="https://github.com/JetBrains/compose-multiplatform-core/assets/1836384/a03926f5-8977-4530-8894-d84aedfd5939">
### Overlapping
```kt
Box(modifier = Modifier.fillMaxSize()) {
SwingPanel(factory = {
JPanel().also { panel ->
panel.background = java.awt.Color.red
panel.add(JButton().also { button ->
button.text = "JButton"
})
}
})
Snackbar(
action = { Button(onClick = {}) { Text("OK") } },
modifier = Modifier.padding(8.dp).align(Alignment.BottomCenter),
) {
Text("Snackbar")
}
Popup(alignment = Alignment.Center) {
Box(
modifier = Modifier.size(200.dp, 100.dp).background(Gray),
contentAlignment = Alignment.Center,
) {
Text("Popup")
}
}
}
```
<img width="592" alt="Screenshot 2023-11-27 at 13 57 43"
src="https://github.com/JetBrains/compose-multiplatform-core/assets/1836384/dda1f2d6-6a1e-456c-8763-46a82d9562a8">
## Issues Fixed
Fixes JetBrains/compose-multiplatform#3823
Fixes JetBrains/compose-multiplatform#3739
Fixes JetBrains/compose-multiplatform#3353
Fixes JetBrains/compose-multiplatform#3474
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for JetBrains/compose-multiplatform-core#915
Fixes #327