-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ligature for "===>" buggy #151
Comments
This doesn't appear as a ligature in Fira or Hasklig either. What language is this symbol used in? |
It's a common sequence in terminal apps. I don't think there needs to be a ligature for ===>, but it would make sense to disable the === ligature when it's followed by a > |
@Midar Can you send the screenshots with its usage, & explain more context. When it's used & for what propose. |
Don't want to speak for @Midar but when using FWIW in case you missed above, Fira Code and Hasklig seem to have the same issue. |
Sometimes this sequence is used as a progress indication, adding more https://www.tecmint.com/wp-content/uploads/2015/10/pv-command-examples.png Here's another progress lib example, though it uses |
Yes, and since The alternative is to change the |
Personally, I wouldn't like |
@qgates No, that's exactly what I meant :). Here's a screenshot of how it looks (first line) and how it should look (second line): Alternatively, of course, there could be a ligature like for ==> - I guess ===> is not that uncommon, and it would look nicer if an app uses several levels, e.g.: ===> Main action that is being done Which, of course, would look inconsistent without a ligature for ===>. But then the question is where to draw the line. ====> maybe? I don't think I've ever seen more than that in these cases. Of course, the least effort and completely sufficient is to just disable the ligature for === if it's followed by anything other than space, alphanumeric or $, as then it's very very unlikely to be used for a comparison. |
As ligatures are meant to provide meaningful symbol replacements, if possible they should probably be disabled in these edge-cases since there is no meaningful Speaking more generally, I'd be curious to know how other ligature fonts like Fira Code or Haskell deal with situations like @thewilkybarkid posts above: I suspect it will be much the same. When ligature fonts are used in a text editor, for given file/syntaxes many modern editors allow ligatures to be enabled or disabled either entirely or for given lexer scopes. This could be a viable workaround for (eg) viewing logs in an editor. Just an opinion, but JBM is designed primarily as a coding font where ligatures are most useful. Perhaps in time a version of the font without ligatures will be available that would better suit general terminal / console use. |
I think disabling the The problem in loading sequence like
Is this a common practice? Seeing it for the first time. What language is this? |
It's quite common for any type of grouped output, or progress output indeed. A similar problem exists with ***, where for two * it's normal as it is for four, but for 3 one is a little higher. I think it's not worth adding a ligature for ===>, but to just disable the === ligature if anything other than [0-9a-zA-Z\s$] is followed, because I don't think having the === ligature followed by an > is something that would ever be wanted. |
— Added No Ligature version. Only in `.ttf` format. It called **JetBrains Mono NL**. #19 — Fixed problems with tiny gaps between the Box Drawing elements. #84 — Balanced the size of `<>` `</>` ligatures to match in mass. #116 — Fixed problem with not working `<--` ligature. #95 — Added `U+FEFF` symbol. No-break zero space. #147 — `<!--` `-->` ligatures now should be on the same heights. #77 — Corrected `===>` behaviour in loading sequences. #151 — Corrected `A` placement in italics. — Made dot in the `0` smaller, so it will be more distinguishable from `8` at small sizes.
— Lowered the height of Powerline arrows #172 — <*> Interpolation bug fix #180 — Removed ligatures from loading sequences [-> [=> #151 — Tuned 1 to be more distinguishable from i in small sizes #176 — Sorted glyphs by unicode order #170 — Added U+02BC "Modifier Letter Apostrophe" #168 — Added new ligature @_ — Added 29 glyphs: ƏəǦǧǪǫǴǵ∀∃∈∋∐⟨⟩∧∨∷∼≈≡⍴■▲▶▼◀◆● — Added support of https://unicodepowersymbol.com/ — Refactored ¶ l j
This changes won't affect the |
Yes, they are. Will remove them in the next update. Thanks! |
Right now, ===> gets rendered as === ligature and > - which looks really strange. Could either the === ligature be disabled if followed by an >, or a ligature for ===> be added?
The text was updated successfully, but these errors were encountered: