Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ligatures in progress bars #968

Closed
tonsky opened this issue Mar 11, 2020 · 11 comments
Closed

Disable ligatures in progress bars #968

tonsky opened this issue Mar 11, 2020 · 11 comments
Labels
Milestone

Comments

@tonsky
Copy link
Owner

tonsky commented Mar 11, 2020

JetBrains/JetBrainsMono#151

@tonsky tonsky added the conflict label Apr 8, 2020
@tonsky tonsky added this to the 3 milestone Apr 8, 2020
@tonsky tonsky closed this as completed in 1d7e14a Apr 9, 2020
@nilp0inter
Copy link

This still happens on progress bars of some command-line programs. Can it be fixed in any way?

For example this is a progress bar that appears when loading a docker image with docker load:

image

@j-f1
Copy link
Contributor

j-f1 commented Jun 1, 2020

Do you have the latest version of Fira Code installed?

@nilp0inter
Copy link

I use Arch and have the latest available version which is 4-1. AFAIK is the latest.

Name            : otf-fira-code
Version         : 4-1
Description     : Monospaced font with programming ligatures
Architecture    : any
URL             : https://github.com/tonsky/FiraCode
Licenses        : custom:OFL
Groups          : None
Provides        : None
Depends On      : None
Optional Deps   : None
Required By     : None
Optional For    : None
Conflicts With  : None
Replaces        : None
Installed Size  : 939.14 KiB
Packager        : Jiachen YANG <[email protected]>
Build Date      : Mon 18 May 2020 07:51:12 AM CEST
Install Date    : Mon 01 Jun 2020 10:15:47 AM CEST
Install Reason  : Explicitly installed
Install Script  : No
Validated By    : Signature

@mfocko
Copy link
Contributor

mfocko commented Jun 1, 2020

Try ttf?

@tonsky
Copy link
Owner Author

tonsky commented Jun 1, 2020

@nilp0inter which terminal are you using?

@nilp0inter
Copy link

@tonsky , I am using QTerminal.

@nilp0inter
Copy link

@mfocko , already tried ttf, same results.

@tonsky
Copy link
Owner Author

tonsky commented Jun 1, 2020

Might be an issue with a terminal. Can you try it in any of the supported editors? Just to make sure?

@nilp0inter
Copy link

I tested using Konsole, exact same result:

image

This is the raw console text it is trying to render:

$ docker load < result                                      
4ce9f247a3c6: Loading layer [==================================================>]  49.66MB/49.66MB

And these are the hashes of the fonts, just in case:

$ pacman -Ql ttf-fira-code | grep '\.ttf' | awk '{print $2}' | xargs md5sum
68e73b469a459295f740f1fc45623996  /usr/share/fonts/TTF/FiraCode-Bold.ttf
cda568e562b21e881c56bfca996a354e  /usr/share/fonts/TTF/FiraCode-Light.ttf
d81ebfe1fe1b9bc96e5c160965b36a4e  /usr/share/fonts/TTF/FiraCode-Medium.ttf
93277bd1b9b89d277b66a3d2147d31d9  /usr/share/fonts/TTF/FiraCode-Regular.ttf
acf90150560a6ec8dfa823bb8ac27d81  /usr/share/fonts/TTF/FiraCode-Retina.ttf
0a3633106a704cd28b1648faa53cfbf3  /usr/share/fonts/TTF/FiraCode-SemiBold.ttf

I will try some more terminals.

@tonsky
Copy link
Owner Author

tonsky commented Jun 3, 2020

Seems to be correct md5. What about e.g. Sublime Text or VS Code, which are known to work? Can you try there?

This is what I see in Apple Terminal:

Screenshot 2020-06-03 at 13 49 45

@tonsky
Copy link
Owner Author

tonsky commented Jun 3, 2020

@nilp0inter let’s continue the discussion in #1064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants