-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/#355 module use support #403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general is good, some case not supported and tests missing. Better to split such huge features (parsing, completion, resolve, inspections) in subtasks and do them sequentially or at least in different commits. One commit should deliver a single idea, not many complex features at once otheriwise it is hard to do code review, check tests coverage, etc.
src/main/kotlin/com/jetbrains/snakecharm/codeInsight/SnakemakeAPI.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/jetbrains/snakecharm/lang/highlighter/SmkSyntaxAnnotator.kt
Show resolved
Hide resolved
src/main/kotlin/com/jetbrains/snakecharm/lang/parser/SmkStatementParsing.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/jetbrains/snakecharm/lang/parser/SmkStatementParsing.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/jetbrains/snakecharm/lang/parser/SmkStatementParsing.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/jetbrains/snakecharm/lang/psi/impl/refs/SmkRuleOrCheckpointNameReference.kt
Show resolved
Hide resolved
src/main/kotlin/com/jetbrains/snakecharm/lang/parser/SmkStatementParsing.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/jetbrains/snakecharm/lang/parser/SmkStatementParsing.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/jetbrains/snakecharm/lang/parser/SmkStatementParsing.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/jetbrains/snakecharm/lang/parser/SmkStatementParsing.kt
Outdated
Show resolved
Hide resolved
fixed:
Answers to some questions:
I've checked and found, that snakemake would use as
Yes :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Not all use syntax support. Maybe is good to look through python impl of use/module parsing in snakemake sources if documentation doesn't cover all cases.
- Also let's make syntax errors look like snakemake runtime error messages for user convenience (although some of our messages IMHO are better, so let's took best from snakemake runtime errors and our impl).
- List of forbidden sections for
use
seems to be different. Here better is to check snakemake python impl details. E.g. 'benchmark' also is not allowe in use, not only execution sections. Also wrong section name result in weird runtime parsing error, so likely list of supported sections is harcoded in snakemake parser class
src/test/resources/features/highlighting/smk_parsing_error.feature
Outdated
Show resolved
Hide resolved
src/test/resources/features/highlighting/smk_parsing_error.feature
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/jetbrains/snakecharm/lang/parser/SmkStatementParsing.kt
Outdated
Show resolved
Hide resolved
src/test/resources/features/highlighting/smk_parsing_error.feature
Outdated
Show resolved
Hide resolved
...in/kotlin/com/jetbrains/snakecharm/codeInsight/completion/SmkKeywordCompletionContributor.kt
Show resolved
Hide resolved
src/main/kotlin/com/jetbrains/snakecharm/codeInsight/SnakemakeAPI.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/jetbrains/snakecharm/lang/psi/impl/refs/SmkRuleOrCheckpointNameReference.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/jetbrains/snakecharm/codeInsight/SnakemakeAPI.kt
Outdated
Show resolved
Hide resolved
fixed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done =)
src/main/kotlin/com/jetbrains/snakecharm/lang/parser/SmkStatementParsing.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/jetbrains/snakecharm/lang/parser/SmkStatementParsing.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/jetbrains/snakecharm/lang/parser/SmkStatementParsing.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/jetbrains/snakecharm/lang/parser/SmkStatementParsing.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/jetbrains/snakecharm/lang/parser/SmkStatementParsing.kt
Outdated
Show resolved
Hide resolved
Resolves: #355
fixed: errors messsages, parsing tests |
'module' and 'use' sections highlighting is done
Resolved: #355