Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax support for Snakemake 6.x 'module' and 'use' concepts #355

Closed
iromeo opened this issue Apr 24, 2021 · 2 comments · Fixed by #403
Closed

Syntax support for Snakemake 6.x 'module' and 'use' concepts #355

iromeo opened this issue Apr 24, 2021 · 2 comments · Fixed by #403
Assignees
@dakochik
Labels
major
Milestone
2021.2.657

Comments

@iromeo
Copy link
Contributor

iromeo commented Apr 24, 2021

Syntax support for Snakemake 6.x 'module' and 'use' concepts. We need at least basic syntax highlighting.
@iromeo iromeo added the major label Apr 24, 2021
dakochik pushed a commit that referenced this issue Jul 22, 2021
fixed: 'module' and 'use' keywords highlighting and basic support
a0f06d4 
Resolves: #355
@iromeo
Copy link
Contributor Author

iromeo commented Jul 26, 2021

In current master not everything is parsed properly:

image
image

dakochik pushed a commit that referenced this issue Jul 27, 2021
fixed: minor fixes in 'use' section parsing, 'replace_prefix' section…
fb874a9 
… is added for 'module' section, 'use' section references now resolving properly

Resolves: #355
dakochik pushed a commit that referenced this issue Jul 27, 2021
fixed: test were misspelled
675e42e 
Resolves: #355
@dakochik
Copy link
Contributor

'module' and 'use' sections highlighting is done:

module use highlighting

@dakochik dakochik mentioned this issue Jul 27, 2021
Merged
dakochik added a commit that referenced this issue Jul 27, 2021
@dakochik
Merge branch 'master' into features/#355-module-use-support
86e9d71
@iromeo iromeo mentioned this issue Jul 27, 2021
Closed
@dakochik dakochik mentioned this issue Jul 28, 2021
Closed
dakochik pushed a commit that referenced this issue Jul 28, 2021
fixed: additional parsing cases, module reference parsing
479c04a 
added: tests for errors, which were highlighted during parsing

Resolves: #355
dakochik pushed a commit that referenced this issue Jul 28, 2021
fixed: use section definition completion for keywords
8b62434 
added: tests for use section highlighting by annotator

Resolves: #355
dakochik pushed a commit that referenced this issue Jul 28, 2021
fixed: use section used rule resolving
02f57b7 
Resolves: #355
dakochik added a commit that referenced this issue Jul 28, 2021
@dakochik
Merge branch 'master' into features/#355-module-use-support
07dd033
dakochik pushed a commit that referenced this issue Jul 28, 2021
fixed: problems after conflict resolving are resolved
60ca728 
Resolves: #355
@iromeo iromeo mentioned this issue Jul 29, 2021
Closed
@iromeo iromeo modified the milestones: use-module-synta, next major Jul 29, 2021
@dakochik dakochik mentioned this issue Jul 30, 2021
Closed
3 tasks
dakochik pushed a commit that referenced this issue Aug 3, 2021
Merge branch 'master' of https://github.com/JetBrains-Research/snakec…
61a703b 
…harm into features/#355-module-use-support

� Conflicts:
�	CHANGELOG.md
dakochik pushed a commit that referenced this issue Aug 3, 2021
fixed: new 'use' use cases is supported (such as single-line declarat…
0c79a6f 
…ion, comma-separated list of imported rules names), additional tests, errors messages are were refactored, highlighting of Snakemake 'from', 'as' and 'with' keywords

Resolves: #355
dakochik pushed a commit that referenced this issue Aug 3, 2021
fixed: 'with' quickfix and its completion are fixed, minor changes in…
5f6371c 
… parsing comments and function calls

Resolves: #355
dakochik pushed a commit that referenced this issue Aug 3, 2021
fixed: resolve logic is restored to previous commits
ea65916 
Resolves: #355
dakochik pushed a commit that referenced this issue Aug 4, 2021
fixed: code is refactored, errors messages are edited
33e30b0 
Resolves: #355
dakochik pushed a commit that referenced this issue Aug 4, 2021
fixed: tests are fixed
8bfe953 
Resolves: #355
iromeo pushed a commit that referenced this issue Aug 5, 2021
@dakochik
Features/#355 module use support (#403)
82271fa 
feat: Basic  'module' and 'use' features support (#355)

Resolves: #355
@iromeo iromeo modified the milestones: use-module-syntax, next major Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dakochik dakochik

Labels
major
Projects
None yet
Milestone
2021.2.657
Development

Successfully merging a pull request may close this issue.

Features/#355 module use support JetBrains-Research/snakecharm
2 participants
@iromeo @dakochik