removeSelected toggle (for multi). Includes example #882
Conversation
|
This is a very needed feature. I've implemented select with categories using optionRenderer. But categories don't make sense when items disappear from them. |
… the same structure/order as 'options'
|
Any updates on this? :-/ |
Bump |
|
Are tests still outdated? if they were fixed, how can I run them again so we can sort out the build? I think the reason this pr has been ignored is because it isn't passing the tests, although it just complains of a failed |
|
Hi. I need this feature at my job. I used your implementation, but when there is many options (menu is scrollable), chosen option always moves to top position. Menu probably should not move at all on click. |
|
It seems like a lot of the code has changed since this was done. Any way to get it updated for the new structure in the upstream repo and get this merged in @dherran? I'd really love to see this feature implemented. |
|
also focus is not set at chosen option (as it probably should be) Also unit tests are a mess, how people do CI here? will it be merged even though tests are failing? I could take @dherran 's commit, merge them to current master and fix any further problems but is there a chance it will get merged in reasonable time? |
|
Any news about this? |
|
I have merged the upstream master into my branch. All changes and samples are there now in sync with the master repo. However, it seems like the master branch build is failing, so in consequence, this pull request also fails. If you need the feature, just pull from my fork until the branch is merged. |
|
Changes Unknown when pulling c12e658 on dherran:remove-selected into ** on JedWatson:master**. |
| @@ -18,7 +18,7 @@ function menuRenderer ({ | |||
| let Option = optionComponent; | |||
|
|
|||
| return options.map((option, i) => { | |||
| let isSelected = valueArray && valueArray.indexOf(option) > -1; | |||
| let isSelected = valueArray && valueArray.findIndex(x => x[valueKey] == option[valueKey]) > -1; | |||
There was a problem hiding this comment.
Instead of including a polyfill what about just using the some method from Array?
| @@ -617,7 +642,12 @@ const Select = React.createClass({ | |||
| inputValue: '', | |||
| focusedIndex: null | |||
| }, () => { | |||
| this.addValue(value); | |||
| var valueArray = this.getValueArray(this.props.value); | |||
| if (valueArray.find(i => i[this.props.valueKey] === value[this.props.valueKey])) { | |||
There was a problem hiding this comment.
Can you also update this to use the some method?
| @@ -21,6 +21,7 @@ var MultiSelectField = React.createClass({ | |||
| }, | |||
| getInitialState () { | |||
| return { | |||
| remove: true, | |||
There was a problem hiding this comment.
nit: use same removeSelected name for state key.
|
@dherran don't mean to step on your toes, but I also needed this feature. I rebased your changes here over Let me know what you think! |
|
@banderson looks good to me. No objection whatsoever. We can work off your PR and close this one whenever. |
|
As mentioned above, PR closed in favor of #1891 |
Added toggle to keep/remove selected options from a multi dropdown. Set to true by default to maintain the current behaviour.
If the option is set to false, clicking an option again will simply remove the element from the array.
Fully tested locally. Works like a charm.