Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate items in multi mode (not delete selected item from list) #874

Closed
khmelevskii opened this issue Apr 7, 2016 · 6 comments
Closed

Comments

@khmelevskii
Copy link

No description provided.

@dherran
Copy link

dherran commented Apr 10, 2016

Would this be it? #882

@kav
Copy link

kav commented Oct 11, 2018

I'm running into a similar issue and it's not quite #882. Say for example I'm picking ice cream flavors for a group of people. Two want chocolate. If I use the existing control the second time I select chocolate rather than it appearing a second time the first chocolate selection will disappear. Not ideal.

I'd love an option to allow duplicates, not sure what trouble that might cause with react keys and whatnot, happy to explore a PR here

@kav
Copy link

kav commented Oct 12, 2018

Looking at v2 this may be doable via the controlled values. I'll investigate there, be nice if I could just tack a gist on for folks

@aleccool213
Copy link

@kav have one available?

@kav
Copy link

kav commented Jun 19, 2019

I forked and made the change here: https://github.com/kav/react-select/commits/1dup That fork is way out of date but if you want to cherry pick those changes for a PR or your own fork by all means go ahead. Let me know if you need a hand with any of it. It's been a while but I could probably get back up to speed fairly quickly

@bladey
Copy link
Contributor

bladey commented May 28, 2020

Hello -

In an effort to sustain the react-select project going forward, we're closing old issues.

We understand this might be inconvenient but in the best interest of supporting the broader community we have to direct our efforts towards the current major version.

If you aren't using the latest version of react-select please consider upgrading to see if it resolves any issues you're having.

However, if you feel this issue is still relevant and you'd like us to review it - please leave a comment and we'll do our best to get back to you!

@bladey bladey closed this as completed May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants