Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix the dependencies issue in config-api plugins #1465 #1470

Closed
wants to merge 3 commits into from
Closed

feat: fix the dependencies issue in config-api plugins #1465 #1470

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3baa7a
feat: fix the dependencies issue
duttarnab May 30, 2022
404f4b7
feat: fix the dependencies issue
duttarnab May 30, 2022
1b6d33e
feat: fix the dependencies and code issues
duttarnab May 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jans-config-api/common/src/main/java/io/jans/configapi/util/ApiConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ private ApiConstants() {}
public static final String USER = "/user";
public static final String ORG = "/org";
public static final String SERVER_STAT = "/server-stat";
public static final String USERNAME_PATH = "{username}";
public static final String USERNAME_PATH = "/{username}";

public static final String LIMIT = "limit";
public static final String START_INDEX = "startIndex";
Expand Down
11 changes: 4 additions & 7 deletions jans-config-api/plugins/admin-ui-plugin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,17 @@
<groupId>io.jans.jans-config-api.plugins</groupId>
<artifactId>admin-ui-plugin</artifactId>

<repositories>
<repository>
<id>jdk-java</id>
<url>https://licensespring-maven.s3.eu-central-1.amazonaws.com/</url>
</repository>
</repositories>

<dependencies>
<!-- config api -->
<dependency>
<groupId>io.jans</groupId>
<artifactId>jans-config-api-shared</artifactId>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>io.jans</groupId>
<artifactId>jans-auth-client</artifactId>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like with @pujavs changes we will get double declaration of the same dependency.

8149133

<dependency>
<groupId>commons-collections</groupId>
<artifactId>commons-collections</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion jans-config-api/plugins/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>io.jans</groupId>
<artifactId>jans-config-api-parent</artifactId>
<version>1.0.0-SNAPSHOT</version>
<version>1.0.1-SNAPSHOT</version>
</parent>

<modelVersion>4.0.0</modelVersion>
Expand Down