Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix the dependencies issue in config-api plugins #1465 #1470

Closed
wants to merge 3 commits into from
Closed

feat: fix the dependencies issue in config-api plugins #1465 #1470

wants to merge 3 commits into from

Conversation

duttarnab
Copy link
Contributor

@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-feature Issue or PR is a new feature request labels May 30, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 30, 2022

[jans-core] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 30, 2022

[orm] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

yuriyz
yuriyz requested changes May 30, 2022
View reviewed changes
jans-config-api/plugins/admin-ui-plugin/pom.xml Outdated
<dependency>
<groupId>io.jans</groupId>
<artifactId>jans-auth-client</artifactId>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like with @pujavs changes we will get double declaration of the same dependency.

8149133

@sonarcloud
Copy link

sonarcloud bot commented May 30, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@duttarnab duttarnab mentioned this pull request May 30, 2022
Merged
@duttarnab
Copy link
Contributor Author

Raising another PR for this task
#1473

@duttarnab duttarnab closed this May 30, 2022
@duttarnab duttarnab deleted the jans-config-api-issue-1465 branch May 31, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz requested changes

@pujavs pujavs Awaiting requested review from pujavs pujavs is a code owner

Assignees
No one assigned
Labels
comp-jans-config-api Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duttarnab @yuriyz @mo-auto