Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add Configuration class and refactor repository retrieval #156

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

JackPlowman
Copy link
Owner

@JackPlowman JackPlowman commented Oct 13, 2024

Pull Request

Description

This change introduces a new Configuration class to centralise and manage configuration settings for the analyser. The main updates include:

  1. Added a new Configuration class in analyser/utils/configuration.py to handle environment variables and configuration settings.

  2. Modified create_statistics function to accept a Configuration object as a parameter.

  3. Updated retrieve_repositories function to use the Configuration object for querying repositories.

  4. Adjusted the main function in __main__.py to create and pass a Configuration object to create_statistics.

  5. Updated test files to accommodate the new Configuration object and modified function signatures.

  6. Moved CataloguedRepository class from analyser/catalogued_repository.py to analyser/utils/catalogued_repository.py.

These changes improve the overall structure of the code by centralising configuration management and making it easier to add or modify configuration settings in the future.

fixes #154

@github-actions github-actions bot added python Pull requests that update Python code analyser Pull requests that update analyser code labels Oct 13, 2024
Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on Graphite Graphite

@JackPlowman JackPlowman force-pushed the 10-13-add_configuration_class branch 2 times, most recently from 12776d0 to ee8ae6b Compare October 14, 2024 17:39
@JackPlowman JackPlowman force-pushed the 10-13-add_configuration_class branch from ee8ae6b to 23d634d Compare October 14, 2024 17:42
@JackPlowman JackPlowman changed the title Add configuration class feat: Add Configuration class and refactor repository retrieval Oct 14, 2024
@JackPlowman JackPlowman changed the title feat: Add Configuration class and refactor repository retrieval build: Add Configuration class and refactor repository retrieval Oct 14, 2024
@JackPlowman JackPlowman marked this pull request as ready for review October 14, 2024 17:42
Copy link

Copy link
Owner Author

JackPlowman commented Oct 14, 2024

Merge activity

  • Oct 14, 1:46 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 14, 1:46 PM EDT: A user merged this pull request with Graphite.

@JackPlowman JackPlowman merged commit 15425e6 into main Oct 14, 2024
45 checks passed
@JackPlowman JackPlowman deleted the 10-13-add_configuration_class branch October 14, 2024 17:46
JackPlowman added a commit that referenced this pull request Oct 20, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.2.0](v1.1.0...v1.2.0)
(2024-10-20)


### 🚀 Features

* Add Debug Mode
([#160](#160))
([2249da5](2249da5)),
closes
[#159](#159)


### 📝 Documentation

* Update README with pre-built image and license info
([#136](#136))
([9ddc6f9](9ddc6f9)),
closes
[#137](#137)


### 🧰 Maintenance

* Add Configuration class and refactor repository retrieval
([#156](#156))
([15425e6](15425e6)),
closes
[#154](#154)
* Add setup-dependencies directory to Dependabot config
([#133](#133))
([44ec79d](44ec79d)),
closes
[#134](#134)
* Add test action and output validation
([#147](#147))
([040eaa8](040eaa8)),
closes
[#148](#148)
* Add version check workflow and version file
([#145](#145))
([19dd4aa](19dd4aa)),
closes
[#146](#146)
* Bump Python Version to Python 3.13
([#140](#140))
([3135efc](3135efc)),
closes
[#139](#139)
* Fix Docker image reference in action.yml
([#149](#149))
([bbfd6f1](bbfd6f1)),
closes
[#150](#150)
* Force color output in logs
([#164](#164))
([2d0d5da](2d0d5da)),
closes
[#163](#163)
* Optimise pre-commit hook for Python files
([#142](#142))
([8e48442](8e48442)),
closes
[#141](#141)
* Reduce log verbosity
([#165](#165))
([1c78547](1c78547)),
closes
[#162](#162)
* Reduce Verbose Logging
([#158](#158))
([94fea82](94fea82)),
closes
[#157](#157)
* Refactor GitHub Action structure and usage
([#143](#143))
([fc7d2d6](fc7d2d6)),
closes
[#144](#144)
* Simplify Docker build job name and description
([#166](#166))
([d94299f](d94299f)),
closes
[#167](#167)
* Update workflow trigger conditions
([#168](#168))
([f96a17a](f96a17a)),
closes
[#169](#169)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyser Pull requests that update analyser code python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create analyser configuration class
1 participant