chore: Optimize pre-commit hook for Python files #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackPlowman
changed the title
github-actions
bot
added
shell
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @JackPlowman and the rest of your teammates on |
|
Merge activity
|
JackPlowman
added a commit
that referenced
this pull request
Oct 11, 2024
This change modifies the `python.sh` script in the `githooks/pre-commit-scripts` directory to conditionally run the `just install` and `just ruff-fix` commands. The script now checks if there are any changes in the `analyser/` folder before executing these commands. This optimisation ensures that the pre-commit hooks only run when necessary, potentially improving the commit process efficiency. fixes #141
JackPlowman
added a commit
that referenced
this pull request
Oct 20, 2024
🤖 I have created a release *beep* *boop* --- ## [1.2.0](v1.1.0...v1.2.0) (2024-10-20) ### 🚀 Features * Add Debug Mode ([#160](#160)) ([2249da5](2249da5)), closes [#159](#159) ### 📝 Documentation * Update README with pre-built image and license info ([#136](#136)) ([9ddc6f9](9ddc6f9)), closes [#137](#137) ### 🧰 Maintenance * Add Configuration class and refactor repository retrieval ([#156](#156)) ([15425e6](15425e6)), closes [#154](#154) * Add setup-dependencies directory to Dependabot config ([#133](#133)) ([44ec79d](44ec79d)), closes [#134](#134) * Add test action and output validation ([#147](#147)) ([040eaa8](040eaa8)), closes [#148](#148) * Add version check workflow and version file ([#145](#145)) ([19dd4aa](19dd4aa)), closes [#146](#146) * Bump Python Version to Python 3.13 ([#140](#140)) ([3135efc](3135efc)), closes [#139](#139) * Fix Docker image reference in action.yml ([#149](#149)) ([bbfd6f1](bbfd6f1)), closes [#150](#150) * Force color output in logs ([#164](#164)) ([2d0d5da](2d0d5da)), closes [#163](#163) * Optimise pre-commit hook for Python files ([#142](#142)) ([8e48442](8e48442)), closes [#141](#141) * Reduce log verbosity ([#165](#165)) ([1c78547](1c78547)), closes [#162](#162) * Reduce Verbose Logging ([#158](#158)) ([94fea82](94fea82)), closes [#157](#157) * Refactor GitHub Action structure and usage ([#143](#143)) ([fc7d2d6](fc7d2d6)), closes [#144](#144) * Simplify Docker build job name and description ([#166](#166)) ([d94299f](d94299f)), closes [#167](#167) * Update workflow trigger conditions ([#168](#168)) ([f96a17a](f96a17a)), closes [#169](#169) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This change modifies the
python.shscript in thegithooks/pre-commit-scriptsdirectory to conditionally run thejust installandjust ruff-fixcommands. The script now checks if there are any changes in theanalyser/folder before executing these commands. This optimization ensures that the pre-commit hooks only run when necessary, potentially improving the commit process efficiency.fixes #141