Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed save order config #9148

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Fixed save order config #9148

merged 1 commit into from
Sep 8, 2022

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Sep 8, 2022

Fixes #9147

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

HoussemNasri
HoussemNasri approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@HoussemNasri HoussemNasri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tried it locally and the issue is gone.

@Siedlerchr Siedlerchr merged commit e970954 into main Sep 8, 2022
@Siedlerchr Siedlerchr deleted the fix-9147 branch September 8, 2022 09:50
Siedlerchr added a commit to LIM0000/jabref that referenced this pull request Sep 10, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-for-issue-8189
1397fc0 
* upstream/main:
  Anomaly with Title case and Sentence case JabRef#9112 (JabRef#9142)
  Fixed save order config (JabRef#9148)
  Update devdocs about fetchers (JabRef#9146)
  Set 'Update refused' dialog title (JabRef#9143)
  Bump jackson-datatype-jsr310 from 2.13.3 to 2.13.4 (JabRef#9136)
  Bump jackson-dataformat-yaml from 2.13.3 to 2.13.4 (JabRef#9138)
  Observable Preferences N (PushToApplicationPreferences, ExternalApplicationPreferences) (JabRef#9135)
  Resimplify Action interface (JabRef#9133)
  Fix issue with empty fallback directory (JabRef#9134)
  Fix indexing (JabRef#9132)
  SLR data is now editable (JabRef#9131)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HoussemNasri HoussemNasri HoussemNasri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export sort order preference is broken
3 participants
@calixtus @HoussemNasri @Siedlerchr