Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resimplify Action interface #9133

Merged
merged 5 commits into from
Sep 4, 2022
Merged

Resimplify Action interface #9133

merged 5 commits into from
Sep 4, 2022

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Sep 4, 2022

Removed ActionImpl and replaced with anonymous classes.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus added jabcon type: code-quality Issues related to code or architecture decisions labels Sep 4, 2022
@calixtus calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 4, 2022
@Siedlerchr Siedlerchr merged commit f240f6d into main Sep 4, 2022
@Siedlerchr Siedlerchr deleted the simplify-action branch September 4, 2022 19:02
Siedlerchr added a commit that referenced this pull request Sep 4, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into version6
7c6b16d 
* upstream/main:
  Resimplify Action interface (#9133)
  Fix issue with empty fallback directory (#9134)
  Fix indexing (#9132)
  SLR data is now editable (#9131)
Siedlerchr added a commit that referenced this pull request Sep 4, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into luceneSearchBackend
85445bd 
* upstream/main:
  Resimplify Action interface (#9133)
  Fix issue with empty fallback directory (#9134)
Siedlerchr added a commit to LIM0000/jabref that referenced this pull request Sep 10, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-for-issue-8189
1397fc0 
* upstream/main:
  Anomaly with Title case and Sentence case JabRef#9112 (JabRef#9142)
  Fixed save order config (JabRef#9148)
  Update devdocs about fetchers (JabRef#9146)
  Set 'Update refused' dialog title (JabRef#9143)
  Bump jackson-datatype-jsr310 from 2.13.3 to 2.13.4 (JabRef#9136)
  Bump jackson-dataformat-yaml from 2.13.3 to 2.13.4 (JabRef#9138)
  Observable Preferences N (PushToApplicationPreferences, ExternalApplicationPreferences) (JabRef#9135)
  Resimplify Action interface (JabRef#9133)
  Fix issue with empty fallback directory (JabRef#9134)
  Fix indexing (JabRef#9132)
  SLR data is now editable (JabRef#9131)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@HoussemNasri HoussemNasri Awaiting requested review from HoussemNasri

Assignees
No one assigned
Labels
jabcon status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers type: code-quality Issues related to code or architecture decisions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calixtus @Siedlerchr