Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open event log when clicking on collapsed notification #8837

Merged
merged 3 commits into from
May 22, 2022
Merged

Open event log when clicking on collapsed notification #8837

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d82783
Open event log when clicking on collapsed notification
claell May 21, 2022
3f3be40
use lambda
Siedlerchr May 21, 2022
e49bf47
Merge remote-tracking branch 'upstream/main' into clel-notification-c…
Siedlerchr May 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/main/java/org/jabref/gui/JabRefDialogService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
import java.util.stream.Collectors;

import javafx.concurrent.Task;
import javafx.event.ActionEvent;
import javafx.event.EventHandler;
import javafx.geometry.Pos;
import javafx.print.PrinterJob;
import javafx.scene.Group;
Expand All @@ -35,6 +37,7 @@
import javafx.stage.Window;
import javafx.util.Duration;

import org.jabref.gui.help.ErrorConsoleAction;
import org.jabref.gui.icon.IconTheme;
import org.jabref.gui.theme.ThemeManager;
import org.jabref.gui.util.BackgroundTask;
Expand Down Expand Up @@ -343,9 +346,16 @@ public void notify(String message) {
.threshold(5,
Notifications.create()
.title(Localization.lang("Last notification"))
// TODO: Change to a notification overview instead of event log when that is available. The event log is not that user friendly (different purpose).
.text(
"(" + Localization.lang("Check the event log to see all notifications") + ")"
+ "\n\n" + message))
+ "\n\n" + message)
.onAction(new EventHandler<ActionEvent>() {
@Override
public void handle(ActionEvent a) {
ErrorConsoleAction ec = new ErrorConsoleAction();
ec.execute();
}}))
.hideCloseButton()
.show();
});
Expand Down