-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open event log when clicking on collapsed notification #8837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea very much. Maybe there should be also a check if the user really left-clicked on the messagebox to avoid unexpected side-effects.
…lick * upstream/main: Add Pubmed/Medline Query Transformer (JabRef#8818) adjust and add testcases for FileAnnotationViewModel (JabRef#8830) Append config instead of replacing (JabRef#8834) Fix eclipse config (JabRef#8835) Add Nemo file manager (JabRef#8831) Fix missing clear action on pressing esc within the "Filter groups" field (JabRef#8829) Update bouncycalse to new base version (JabRef#8827) add: add test cases for FileUtil (JabRef#8810) Restrict use of standard streams (JabRef#8816) updated 8802 (JabRef#8817)
@claell Thanks for the work! Looks good to me. The issue with the empty event log was fixed recently. Your fork was not yet up to date |
Good point, I'll check on that when I have time. @Siedlerchr thanks for the hint with the empty log, I already feared that this was related to my not up to date fork. |
I would merge this in now to reduce the number of PRs. Works fine and we still can create a follow up PR. |
…-masked-characters#8787 * upstream/main: Add: Add test cases for non-default styles in CitationStyleTest (JabRef#8828) Open event log when clicking on collapsed notification (JabRef#8837) Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected (JabRef#8821) Fix single identifier cannot be opened on click (JabRef#8838) Add Pubmed/Medline Query Transformer (JabRef#8818) adjust and add testcases for FileAnnotationViewModel (JabRef#8830) Append config instead of replacing (JabRef#8834) Fix eclipse config (JabRef#8835) Add Nemo file manager (JabRef#8831) Fix missing clear action on pressing esc within the "Filter groups" field (JabRef#8829) Update bouncycalse to new base version (JabRef#8827) add: add test cases for FileUtil (JabRef#8810) Restrict use of standard streams (JabRef#8816)
@calixtus I just checked the behavior. It is correct, also right mouse button clicks and probably further actions can trigger this. I didn't find a fast solution to this, though. I don't know, how to add an event handler for |
Adding a custom subclass of |
In #8775 (comment), I suggested a change for collapsed notifications to improve their UX. Since this has not been implemented there, I went ahead with my own approach.
The collapsed notifications contain a hint to the event log. However, for users, it is likely tiresome to find the menu entry and open the event log from there. Thus, when clicking the collapsed notification, the event log opens now.
Not sure, whether the way I did it is clean, so open for feedback.
An additional thing I noticed is that the event log is empty for me (not the case on the stable build). Probably not related, possibly, an issue should be created for it.
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)