Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for FieldChange Class #8614

Merged
merged 5 commits into from
Mar 31, 2022
Merged

Add more tests for FieldChange Class #8614

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0e32494
Add more tests for FieldChange Class
CarlosZoft Mar 27, 2022
bc002fa
Fix order of imports
CarlosZoft Mar 27, 2022
bdef01b
Fix improving visualization of self equals test
CarlosZoft Mar 28, 2022
fba3c21
Fix improving semantically
CarlosZoft Mar 28, 2022
9002de3
Merge branch 'main' of github.com:CarlosZoft/jabref into carloszoft-m…
CarlosZoft Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/test/java/org/jabref/model/FieldChangeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,24 @@ void equalFieldChange() {
assertNotEquals(fc, fcBlankNewValue);
}

@Test
void selfEqualsFieldchangeSameParameters() {
FieldChange fcBlankNewValue = new FieldChange(entry, StandardField.DOI, "foo", "bar");
assertEquals(fc, fcBlankNewValue);
}

@Test
void selfEqualsFieldchangeDifferentOldValue() {
FieldChange fcBlankNewValue = new FieldChange(entry, StandardField.DOI, null, "bar");
assertNotEquals(fc, fcBlankNewValue);
}

@Test
void selfEqualsFieldchangeDifferentEntry() {
FieldChange fcBlankNewValue = new FieldChange(entryOther, StandardField.DOI, "foo", "bar");
assertNotEquals(fc, fcBlankNewValue);
}

@Test
void fieldChangeDoesNotEqualString() {
assertNotEquals(fc, "foo");
Expand Down