Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests for FieldChange Class #8614

Merged
merged 5 commits into from
Mar 31, 2022
Merged

Add more tests for FieldChange Class #8614

merged 5 commits into from
Mar 31, 2022

Conversation

CarlosZoft
Copy link
Contributor

Description :

Testing using self equals method of class FieldChange

  • Adding new tests

koppor
koppor requested changes Mar 28, 2022
View reviewed changes
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace assertTrue and assertFalse semantically (!) by assertEquals. I provided an example below.

src/test/java/org/jabref/model/FieldChangeTest.java Outdated Show resolved Hide resolved
@koppor koppor added the status: changes required Pull requests that are not yet complete label Mar 28, 2022
@CarlosZoft CarlosZoft requested a review from koppor March 28, 2022 20:38
@CarlosZoft
Copy link
Contributor Author

Thanks for review, I think the visualization is better now.

koppor
koppor approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the CI shows failing unit tests, the failing tests are not related to these changes.

@calixtus calixtus merged commit 0536a39 into JabRef:main Mar 31, 2022
@calixtus
Copy link
Member

Thanks for your addition to our test suite. Are you interested in working on JabRef more? We would be happy to answer your questions in our gitter channel, if you like.

@CarlosZoft
Copy link
Contributor Author

thanks for the invitation, i'll keep contributing!

Siedlerchr added a commit that referenced this pull request Apr 5, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into lucenceUpgrade
4dcb7f8 
* upstream/main:
  Remove obsolete comments
  Improve key generation (#8641)
  Refine search code (#8636)
  Fix import entry by id does not generate citation key (#8361)
  Update Gradle Wrapper from 7.4.1 to 7.4.2. (#8637)
  Bump hmarr/auto-approve-action from 2.1.0 to 2.2.0 (#8638)
  GitBook: [#57] test
  Citation keygen: Return vonPart if lastName is empty (#8634)
  Ensure SSL truststore is present at startup (#8631)
  Squashed 'buildres/csl/csl-styles/' changes from 6a7b708..21e2177 (#8632)
  Add more tests for FieldChange Class (#8614)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr left review comments

@calixtus calixtus calixtus approved these changes

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
status: changes required Pull requests that are not yet complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CarlosZoft @calixtus @Siedlerchr @koppor