Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snap: Remove superfluous files post build #8319

Merged
merged 1 commit into from
Dec 11, 2021
Merged

snap: Remove superfluous files post build #8319

merged 1 commit into from
Dec 11, 2021

Conversation

ppd
Copy link
Contributor

@ppd ppd commented Dec 11, 2021

The cleanup part will remove any files that have been
included in the snap during build that also exist in the
content snap.

This reduces the size from 230 MB to 178 MB (~23%),
which improves startup & download speed.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@ppd
snap: Remove superfluous files post build
f3995bf 
The cleanup part will remove any files that have been
included in the snap during build that also exist in the
content snap.

This reduces the size from 230 MB to 178 MB (~23%),
which improves startup & download speed.
@Siedlerchr Siedlerchr added platform: snap When JabRef is run as a snap on linux status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Dec 11, 2021
@Siedlerchr
Copy link
Member

Thank you very much for your PR!

LyzardKing
LyzardKing reviewed Dec 11, 2021
View reviewed changes
Copy link
Collaborator

@LyzardKing LyzardKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @ppd! I didn't think of adding this part, but it is indeed very useful!
I think we can mege this and test it once in the edge channel

@Siedlerchr Siedlerchr merged commit 55023e9 into JabRef:main Dec 11, 2021
@ppd ppd deleted the snap-cleanup branch December 11, 2021 23:37
Siedlerchr added a commit that referenced this pull request Dec 12, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/main'
dd2afac 
* upstream/main:
  New translations JabRef_en.properties (Turkish) (#8321)
  snap: Remove superfluous files post build (#8319)
  Fix IEEE test (#8320)
  New translations JabRef_en.properties (German) (#8318)
  Fixed exception handling (#8314)
Siedlerchr added a commit that referenced this pull request Dec 12, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into tinylog
d86bcfe 
* upstream/main:
  New translations JabRef_en.properties (Turkish) (#8321)
  snap: Remove superfluous files post build (#8319)
  Fix IEEE test (#8320)
  New translations JabRef_en.properties (German) (#8318)
  Fixed exception handling (#8314)
  New Crowdin updates (#8312)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LyzardKing LyzardKing LyzardKing left review comments

Assignees
No one assigned
Labels
platform: snap When JabRef is run as a snap on linux status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ppd @Siedlerchr @LyzardKing