Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed exception handling #8314

Merged
merged 1 commit into from
Dec 11, 2021
Merged

Fixed exception handling #8314

merged 1 commit into from
Dec 11, 2021

Conversation

stoianmihail
Copy link
Contributor

@stoianmihail stoianmihail commented Dec 9, 2021 •
edited by Siedlerchr
Loading

Fixes #8313

Siedlerchr
Siedlerchr reviewed Dec 9, 2021
View reviewed changes
src/main/java/org/jabref/gui/collab/StringRemoveChangeViewModel.java
@@ -28,7 +28,7 @@ public void makeChange(BibDatabaseContext database, NamedCompound undoEdit) {
database.getDatabase().removeString(string.getId());
undoEdit.addEdit(new UndoableRemoveString(database.getDatabase(), string));
} catch (Exception ex) {
LOGGER.warn("Error: could not add string '" + string.getName() + "': " + ex.getMessage(), ex);
LOGGER.warn("Error: could not remove string '" + string.getName() + "': " + ex.getMessage(), ex);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, however, you can improve the code even more by using the parameteriezd version: http://slf4j.org/faq.html#paramException

@Siedlerchr Siedlerchr merged commit a74253e into JabRef:main Dec 11, 2021
Siedlerchr added a commit that referenced this pull request Dec 12, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/main'
dd2afac 
* upstream/main:
  New translations JabRef_en.properties (Turkish) (#8321)
  snap: Remove superfluous files post build (#8319)
  Fix IEEE test (#8320)
  New translations JabRef_en.properties (German) (#8318)
  Fixed exception handling (#8314)
Siedlerchr added a commit that referenced this pull request Dec 12, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into tinylog
d86bcfe 
* upstream/main:
  New translations JabRef_en.properties (Turkish) (#8321)
  snap: Remove superfluous files post build (#8319)
  Fix IEEE test (#8320)
  New translations JabRef_en.properties (German) (#8318)
  Fixed exception handling (#8314)
  New Crowdin updates (#8312)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[StringRemoveChangeViewModel] Exception
2 participants
@stoianmihail @Siedlerchr