Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if online file before downloading link #8144

Merged
merged 3 commits into from
Oct 13, 2021
Merged

Check if online file before downloading link #8144

merged 3 commits into from
Oct 13, 2021

Conversation

btut
Copy link
Contributor

@btut btut commented Oct 13, 2021

When importing, JabRef offers an option to download online files. This PR adds a check that files are indeed online links before downloading.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Anything else you want to do because it's marked as draft?

@btut
Copy link
Contributor Author

btut commented Oct 13, 2021

Issue was reported by @koppor, would like to wait for him to confirm it is fixed. Sorry, should have put that in the description.

@koppor
Copy link
Member

koppor commented Oct 13, 2021

The PDF was https://link.springer.com/book/10.1007/978-3-319-47590-5.

Step 1:

grafik

Step 2:

grafik

Works now. However, I should not use that way in the concrete case. I should merely import the DOI and then download the PDF.

@koppor koppor marked this pull request as ready for review October 13, 2021 22:19
@koppor koppor merged commit dfae8e2 into main Oct 13, 2021
@koppor koppor deleted the Issue8143 branch October 13, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants