[WIP] Jabrefonline apollo

[Siedlerchr]

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

[Siedlerchr]

@tobiasdiez I theoretically fixed all this modularity stuff, however, now I am having troubles with Kotlin shit

Users/christophs/workspace/jabref/build/generated/source/apollo/main/service/GetDocumentByIdQuery.java:277: error: cannot access Function1
        final GetUserDocumentRaw getUserDocumentRaw = reader.readObject($responseFields[0], new ResponseReader.ObjectReader<GetUserDocumentRaw>() {
                                                            ^
  class file for kotlin.jvm.functions.Function1 not found
/Users/christophs/workspace/jabref/build/generated/source/apollo/main/service/GetDocumentByIdQuery.java:342: error: cannot access Function2
          writer.writeList($responseFields[3], fields, new ResponseWriter.ListWriter() {
                ^

[Siedlerchr]

Screw this Apollo. Isn't there a better client?

[tobiasdiez]

Should work now...the kotlin reference is a module, so need to be required explicitly in the module spec

[Siedlerchr]

Ah yes thanks! compiles. Now I have to adapt the output package

[tobiasdiez]

apollographql/apollo-kotlin#2019

Probably just add the current path to the sourceset.

[Siedlerchr]

Now I only need to get it working in Eclipse^^
Eclipse doesn't like the patch modules somehow. Would be interesting if this works in Intellij.

[koppor]

As far as I understand the motivation, this makes JabRef a server for some online clients.

I would like to take this as a chance to work on a gradle multi module build (follow-up to #3704).

[koppor]

This PR adds a new binary file:

I would like to see that file (apollo-api-jvm-2.5.8.jar) being added in a seperate module only - and keep the normal build "clean".

(I assume, the dependency isn't https://mvnrepository.com/artifact/com.apollographql.apollo/apollo-compiler/2.5.8)

[Siedlerchr]

@koppor This is the dependency https://mvnrepository.com/artifact/com.apollographql.apollo/apollo-api-jvm
The problem is that apollo.runtime is a split package and we patch it with the api module

[tobiasdiez]

As far as I understand the motivation, this makes JabRef a server for some online clients.

Nope, it makes JabRef online a possible server that JabRef can sync with (in addition to the Postgres, MySql, ... databases we already support). The apollo stuff we add is a client not a server (it consumes the JabRef online api).

[koppor]

DevCall: Try it out in IntelliJ (and explain to koppor ^^)

[Siedlerchr]

./gradlew generateApolloSources

[Siedlerchr]

No matter what I try, I can't get the patched module stuff working in Eclipse.

[tobiasdiez]

So the imports are not working, or what is the problem?

[Siedlerchr]

As this is still heavy WIP I will move this to koppor to

[Siedlerchr]

Now located at JabRef#505

[tobiasdiez]

I would say we create a very minimal initial version that works, and then take this as the base branch for further PRs.

What is the problem with this branch though? Anything else that is not working than the eclipse integration?

[Siedlerchr]

The key problem is that a) Eclipse is not working with the patched module, it won't compile and can't find the module when it's located in runtime and b) there was also a problem with the mutation code generation. Need to try this out again.

[Siedlerchr]

As a workaround I tried to manually patch the module like we did with LO before but this did not work
https://bugs.eclipse.org/bugs/show_bug.cgi?id=529923
https://wiki.eclipse.org/Java9/ModularityOptions