Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Multi module build #3704

Closed
wants to merge 90 commits into from
Closed

[WIP] Multi module build #3704

wants to merge 90 commits into from

Conversation

koppor
Copy link
Member

@koppor koppor commented Feb 7, 2018

This is a huge step towards #110 and prepares #3421 somehow.

This enables gradle multi module build.

The dependencies of "logic" were not as clean as I thought. I removed dependencies to GUI or moved packages back to gui (shared, remote).

We should get this in ASAP.

Open issues:

  • src/main/gen should be removed from version control - generated code like jabref.gui/src/main/gen/org/jabref/logic/importer/fileformat/mods/RoleTermDefinition.java is put under version control; is this desired?
  • inherit more from root project avoid duplication of plugins dependencies and tasks (https://docs.gradle.org/current/userguide/multi_project_builds.html)
  • GUI does not start: Cannot load file GroupTree.fxml
  • Install4J does not find the generated JARs.
  • The OO preferences should be fixed (reading/writing not fully supported yet). All other features should work. - done in Prepare multi module build #3913
  • jar are not uploaded to CircleCI - are they stored somewhere else? http://builds.jabref.org/multi-module-build/
  • Tests not executed on travis. :org.jabref.gui:junitPlatformTest - this works locally though.
  • Tests fail on travis. E.g., [main] ERROR org.jabref.logic.l10n.Localization - Messages are not initialized before accessing All entries

@koppor koppor added the jabcon label Feb 7, 2018
@koppor koppor changed the title Multi module build [WIP] Multi module build Feb 7, 2018
@tobiasdiez
Copy link
Member

The fxml and css files should lie in the same folder as the view GroupTreeView


import java.nio.charset.Charset;

public class SavePreferencesFactory {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just move these methods to JabRefPreferences.

@koppor koppor force-pushed the multi-module-build branch from 732300e to df4ef0d Compare February 7, 2018 09:33
@koppor koppor force-pushed the multi-module-build branch from 8a91c8b to 0c96e14 Compare February 8, 2018 14:55
# Conflicts:
#	org.jabref.gui/src/test/java/org/jabref/SearchQueryHighlightListenerTest.java
#	org.jabref.gui/src/test/java/org/jabref/gui/importer/EntryFromFileCreatorManagerTest.java
#	org.jabref.gui/src/test/java/org/jabref/gui/importer/EntryFromPDFCreatorTest.java
#	org.jabref.gui/src/test/java/org/jabref/preferences/LastFocusedTabPreferencesTest.java
#	org.jabref.logic/src/test/java/org/jabref/logic/xmp/XMPSchemaBibtexTest.java
#	org.jabref.model/src/test/java/org/jabref/model/strings/StringUtilTest.java
#	src/jmh/java/org/jabref/preferences/LastFocusedTabPreferencesTest.java
#	src/test/java/org/jabref/CodeStyleTests.java
#	src/test/java/org/jabref/logic/importer/DatabaseFileLookupTest.java
#	src/test/java/org/jabref/preferences/LastFocusedTabPreferencesTest.java
@koppor
Copy link
Member Author

koppor commented Feb 14, 2018

Solved via 9bfea57

Current state: Compiles fine on Windows, but on Linux:

FAILURE: Build failed with an exception.

* Where:
Build file '/home/ubuntu/jabref/org.jabref.logic/build.gradle' line: 73

* What went wrong:
Execution failed for task ':org.jabref.logic:processResources'.
> No signature of method: static org.gradle.api.Project.getRootProject() is applicable for argument types: () values: []

Reproducible via

docker run -it --rm --name my-maven-project -v "d:/git-repositories/jabref/jabref:/usr/src/mymaven" -w /usr/src/mymaven jabref/javafx ./gradlew release

@@ -1,5 +1,6 @@
# no generated files in version control
src/main/gen/
**/src/main/gen/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generated code like jabref.gui/src/main/gen/org/jabref/logic/importer/fileformat/mods/RoleTermDefinition.java is put under version control; is this desired?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should not happen. We have to remove that code.

I will double check.

# Conflicts:
#	org.jabref.gui/src/main/java/org/jabref/JabRefMain.java
@koppor
Copy link
Member Author

koppor commented Feb 18, 2018

This will be frozen until #3733 is merged. Reason: That PR also does huge refactorings.

@koppor
Copy link
Member Author

koppor commented Mar 31, 2018

I close this PR as this is unfinished.

I created #3913 as follow up. The small changes are filed as PRs #3907, #3908, #3909, #3910, #3911, #3912

The only thing not followed-up is the gradle multi-module-build (Co-Authored-By @stefan-kolb). I propose to leave it to @florian-beetz to investigate the gradle scripts and see whether they help him to get JabRef ready for Java9.

@koppor koppor closed this Mar 31, 2018
@koppor koppor removed the jabcon label Mar 31, 2018
@stefan-kolb stefan-kolb deleted the multi-module-build branch August 23, 2019 20:25
@koppor koppor mentioned this pull request Jun 7, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants