Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Group color not imported after closing the app #7096

Closed
wants to merge 2 commits into from
Closed

Fixing Group color not imported after closing the app #7096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb8ac4b
Calling addGroupDetails() before returning the
HoussemNasri Nov 14, 2020
9a43cef
add issue fixed to CHANGELOG.md
HoussemNasri Nov 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ inserting new citations in a OpenOffic/LibreOffice document. [#6957](https://git
- We fixed an issue where modifications to the Custom preview layout in the preferences were not saved [#6447](https://github.com/JabRef/jabref/issues/6447)
- We fixed an issue where errors from imports were not shown to the user [#7084](https://github.com/JabRef/jabref/pull/7084)
- We fixed an issue where the EndNote XML Import would fail on empty keywords tags [forum#2387](https://discourse.jabref.org/t/importing-in-unknown-format-fails-to-import-xml-library-from-bookends-export/2387)
- We fixed an issue where the color of groups of type "free search expression" not persisting after restarting the application [#6999](https://github.com/JabRef/jabref/issues/6999)

### Removed

Expand Down
6 changes: 4 additions & 2 deletions src/main/java/org/jabref/logic/importer/util/GroupsParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public static GroupTreeNode importGroups(List<String> orderedData, Character key
/**
* Re-create a group instance from a textual representation.
*
* @param s The result from the group's toString() method.
* @param s The result from the group's toString() method.
* @return New instance of the encoded group.
* @throws ParseException If an error occurred and a group could not be created, e.g. due to a malformed regular expression.
*/
Expand Down Expand Up @@ -278,9 +278,11 @@ private static AbstractGroup searchGroupFromString(String s) {
boolean regExp = Integer.parseInt(tok.nextToken()) == 1;
// version 0 contained 4 additional booleans to specify search
// fields; these are ignored now, all fields are always searched
return new SearchGroup(name,
SearchGroup searchGroup = new SearchGroup(name,
GroupHierarchyType.getByNumberOrDefault(context), expression, caseSensitive, regExp
);
addGroupDetails(tok, searchGroup);
return searchGroup;
}

private static void addGroupDetails(QuotedStringTokenizer tokenizer, AbstractGroup group) {
Expand Down