-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Group color not imported after closing the app #7096
Conversation
parsed group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for digging into this issue and finding a solution! Most welcome!
Codewiese looks good to me!
@Siedlerchr Thanks for looking into my code, I am new to open source and git & github so i have some questions if you don't mind:
|
@HoussemNasri Thanks for chosing JabRef! Your contirbution is most welcome 😼 If you didn't work on a fetcher, you can ignore the fetcher tests. They are often failing because of timeouts or that the Gihub Runner is blocked. Regarding Changelog: The Changelog is for the users to see what is fixed in each version. Therefore, just add a line describing which problem is fixed now. Just add another commit and the PR will be udpated automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to JabRef! Your changes look good to me.
@koppor Author test fails for some reason, with the following text:
The JabRef maintainers will add the following name to the AUTHORS file
Houssem
Houssem Nasri
HoussemNasri
I guess the second one is correct. Not sure what to do, so I let you merge.
@tobiasdiez yes it's the second one, I think this happened because I changed my user.name in git |
Squashed-and-Merged using the command line. @HoussemNasri Thank you for the contribution |
I believe this closes #6999 (which has not happened automatically)? |
Hi, I found the bug Group's color not saved #6999, it's caused by
org.jabref.logic.importer.util.GroupParser.searchGroupFromString()
, the problem is when parsing a search group most of the properties gets parsed bysearchGroupFromString()
but some properties like (expanded, color, iconName, description) gets parsed by another methodaddGroupDetails()
to fix it instead of returning
searchGroup
right away i calledaddGroupDetails()
onsearchGroup
to add the missing properties then I returnedsearchGroup
Fixes Group's color not saved #6999
Change in CHANGELOG.md described (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.