try to fix DEP issue with official jdk #7008
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,10 +55,15 @@ jobs: | |
| - name: Run GitVersion | ||
| id: gitversion | ||
| uses: gittools/actions/gitversion/[email protected] | ||
| - name: Setup JDK 15 from jdk.java.net | ||
| uses: sormuras/download-jdk@v1 | ||
| with: | ||
| feature: 15 | ||
| - uses: actions/setup-java@v1 | ||
|
There was a problem hiding this comment. This stems from the MWE https://github.com/sormuras/download-jdk#minimal-example-with-default-feature-and-using-environment-variables. Maybe we should provide a PR for them, too? |
||
| with: | ||
| java-version: ${{ env.JDK_VERSION }} | ||
| jdkFile: ${{ env.JDK_FILE }} | ||
| - run: java --version | ||
|
There was a problem hiding this comment. Remove this (debug statement)? There was a problem hiding this comment. This stems from the MWE https://github.com/sormuras/download-jdk#minimal-example-with-default-feature-and-using-environment-variables. I also thought about its usefulenes. Since there is not the concept of LOGGER.debug and Logger configuration, I would keep it to ensure quick debugging. We will surely have regularly JDK issues the next years. |
||
| - name: Restore gradle cache | ||
| uses: actions/cache@master | ||
| with: | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setup -> Download
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not from https://github.com/sormuras/download-jdk#minimal-example-with-default-feature-and-using-environment-variables (is it?), thus I am fine with this change.