try to fix DEP issue with official jdk #7008

Siedlerchr · 2020-10-12T14:53:42Z

Change in CHANGELOG.md described (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

koppor

The implementation uses the minimal example of sormuras/download-jdk. --> https://github.com/sormuras/download-jdk#minimal-example-with-default-feature-and-using-environment-variables

LGTM

Siedlerchr · 2020-10-12T20:57:19Z

Please wait with merging. Needs testing. First of all the windows build needs to run... Some plug-in repos seem to be reachable

tobiasdiez

Strange that there are errors due to different JDKs...that shouldn't happen :(

Thanks for fixing it.

tobiasdiez · 2020-10-13T09:56:58Z

.github/workflows/deployment.yml

@@ -55,10 +55,15 @@ jobs:
      - name: Run GitVersion
        id: gitversion
        uses: gittools/actions/gitversion/[email protected]
-      - name: Set up JDK
-        uses: actions/setup-java@v1
+      - name: Setup JDK 15 from jdk.java.net


Setup -> Download

This is not from https://github.com/sormuras/download-jdk#minimal-example-with-default-feature-and-using-environment-variables (is it?), thus I am fine with this change.

tobiasdiez · 2020-10-13T09:57:11Z

.github/workflows/deployment.yml

        with:
-          java-version: 15
+          feature: 15
+      - uses: actions/setup-java@v1


Add name "Setup JDK"

This stems from the MWE https://github.com/sormuras/download-jdk#minimal-example-with-default-feature-and-using-environment-variables. Maybe we should provide a PR for them, too?

tobiasdiez · 2020-10-13T09:57:26Z

.github/workflows/deployment.yml

+        with:
+          java-version: ${{ env.JDK_VERSION }}
+          jdkFile: ${{ env.JDK_FILE }}
+      - run: java --version


Remove this (debug statement)?

This stems from the MWE https://github.com/sormuras/download-jdk#minimal-example-with-default-feature-and-using-environment-variables. I also thought about its usefulenes. Since there is not the concept of LOGGER.debug and Logger configuration, I would keep it to ensure quick debugging. We will surely have regularly JDK issues the next years.

Siedlerchr · 2020-10-13T15:18:25Z

Unfortunately still crashes with DEP. I got a bug ID now.
https://bugs.openjdk.java.net/browse/JDK-8254697

tobiasdiez · 2020-10-13T20:19:06Z

Looks like it's indeed a bug in the OpenJDK. So I guess we need to go back to JDK 14 (at least for Windows).

Siedlerchr · 2020-10-13T20:22:10Z

@tobiasdiez Yep, until the bug is fixed I would add the switch as before, this time only for windows. Shouldn't affect development as we still are on 14 in gradle etc. I will do that tomorrow.

* upstream/master: Jstor Fetcher (#6992) Group: "Searching for keywords" searches for a single keyword ==> use singular (#6995) Merge parsing of bracketed patterns (#6989) 6848 fixed the issue of clicking collapse all expanding tree (#6993) Enable auto sync per default for Open/Libre Office (#6985) Bump unirest-java from 3.11.00 to 3.11.01 (#7001) Bump byte-buddy-parent from 1.10.16 to 1.10.17 (#7004) Bump lucene-queryparser from 8.6.2 to 8.6.3 (#7002) Bump postgresql from 42.2.16 to 42.2.17 (#7005) Bump pascalgn/automerge-action from v0.11.0 to v0.12.0 (#7006) Bump flowless from 0.6.1 to 0.6.2 (#7003)

* upstream/master: Update journalList.mv Update to javafx15 (#7018) Squashed 'src/main/resources/csl-styles/' changes from 6fab78b..5297abd try to fix DEP issue with official jdk (#7008) Jstor Fetcher (#6992) Group: "Searching for keywords" searches for a single keyword ==> use singular (#6995) Merge parsing of bracketed patterns (#6989) 6848 fixed the issue of clicking collapse all expanding tree (#6993) Enable auto sync per default for Open/Libre Office (#6985) Bump unirest-java from 3.11.00 to 3.11.01 (#7001) Bump byte-buddy-parent from 1.10.16 to 1.10.17 (#7004) Bump lucene-queryparser from 8.6.2 to 8.6.3 (#7002) Bump postgresql from 42.2.16 to 42.2.17 (#7005) Bump pascalgn/automerge-action from v0.11.0 to v0.12.0 (#7006) Bump flowless from 0.6.1 to 0.6.2 (#7003)

* upstream/master: (58 commits) remove any newlines and spaces in isbn when fetching (#7023) add exception to error handler in integrity check Update journalList.mv Update to javafx15 (#7018) Squashed 'src/main/resources/csl-styles/' changes from 6fab78b..5297abd try to fix DEP issue with official jdk (#7008) Jstor Fetcher (#6992) Group: "Searching for keywords" searches for a single keyword ==> use singular (#6995) Merge parsing of bracketed patterns (#6989) 6848 fixed the issue of clicking collapse all expanding tree (#6993) Enable auto sync per default for Open/Libre Office (#6985) Bump unirest-java from 3.11.00 to 3.11.01 (#7001) Bump byte-buddy-parent from 1.10.16 to 1.10.17 (#7004) Bump lucene-queryparser from 8.6.2 to 8.6.3 (#7002) Bump postgresql from 42.2.16 to 42.2.17 (#7005) Bump pascalgn/automerge-action from v0.11.0 to v0.12.0 (#7006) Bump flowless from 0.6.1 to 0.6.2 (#7003) Rewrite guidelines to Java 15 (#6973) Lint CHANGELOG.md Removing "BibTeX" when not specific to BibTeX (#6983) ...

Siedlerchr added 2 commits October 12, 2020 16:52

try with official jdk

6661ea1

I hate yaml

439924c

koppor approved these changes Oct 12, 2020

View reviewed changes

Siedlerchr changed the title ~~try to fix DEP issue with official jdk~~ [wip] try to fix DEP issue with official jdk Oct 12, 2020

koppor mentioned this pull request Oct 12, 2020

switch back to adoptopenjdk to fix DEP issues on windows #6988

Closed

5 tasks

tobiasdiez requested changes Oct 13, 2020

View reviewed changes

Siedlerchr added the status: depends-on-external A bug or issue that depends on an update of an external library label Oct 13, 2020

Siedlerchr added 2 commits October 14, 2020 21:39

Downgrade to jdk 14 until the JDK 15 bug for windows is solved

9db33d1

Siedlerchr changed the title ~~[wip] try to fix DEP issue with official jdk~~ try to fix DEP issue with official jdk Oct 14, 2020

Siedlerchr merged commit a768f6e into master Oct 14, 2020

Siedlerchr deleted the winBuild branch October 14, 2020 20:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

try to fix DEP issue with official jdk #7008

try to fix DEP issue with official jdk #7008

Siedlerchr commented Oct 12, 2020 •

edited

Loading

koppor left a comment

Siedlerchr commented Oct 12, 2020

tobiasdiez left a comment

tobiasdiez Oct 13, 2020

koppor Oct 13, 2020

tobiasdiez Oct 13, 2020

koppor Oct 13, 2020

tobiasdiez Oct 13, 2020

koppor Oct 13, 2020

Siedlerchr commented Oct 13, 2020

tobiasdiez commented Oct 13, 2020

Siedlerchr commented Oct 13, 2020

try to fix DEP issue with official jdk #7008

try to fix DEP issue with official jdk #7008

Conversation

Siedlerchr commented Oct 12, 2020 • edited Loading

koppor left a comment

Choose a reason for hiding this comment

Siedlerchr commented Oct 12, 2020

tobiasdiez left a comment

Choose a reason for hiding this comment

tobiasdiez Oct 13, 2020

Choose a reason for hiding this comment

koppor Oct 13, 2020

Choose a reason for hiding this comment

tobiasdiez Oct 13, 2020

Choose a reason for hiding this comment

koppor Oct 13, 2020

Choose a reason for hiding this comment

tobiasdiez Oct 13, 2020

Choose a reason for hiding this comment

koppor Oct 13, 2020

Choose a reason for hiding this comment

Siedlerchr commented Oct 13, 2020

tobiasdiez commented Oct 13, 2020

Siedlerchr commented Oct 13, 2020

Siedlerchr commented Oct 12, 2020 •

edited

Loading