Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix icon issue #6858

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Fix icon issue #6858

merged 1 commit into from
Sep 3, 2020

Conversation

fabiojavamarcos
Copy link
Contributor

Fixes #6834

Changed the link used when we have only one entry to a single chain.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

image

@DominikVoigt
Copy link
Contributor

DominikVoigt commented Sep 3, 2020 •
edited
Loading

Thanks for your contribution!
I think that the icon that is currently used for entries with multiple DOIs should be used for entries with one DOI, and entries with multiple DOIs should use a new dedicated icon.

Propose:
image

@calixtus
Copy link
Member

calixtus commented Sep 3, 2020

Problem: We only use FontAwesomeIcons/MaterialDesign icons, implementation of custom icons is a bit more effort.
My suggestion: merge this as a quick fix to distinguish better between both types and see, if we can find a better icon soon.

@tobiasdiez tobiasdiez merged commit 1283f9f into JabRef:master Sep 3, 2020
@fabiojavamarcos fabiojavamarcos deleted the fiz-issue-6834 branch September 3, 2020 15:58
Siedlerchr added a commit that referenced this pull request Sep 4, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into writebackupToTemp
1043d9e 
* upstream/master:
  Fix icon issue (#6858)
  No sync of specialfields to keywords as default (#6846)
  Don't show entry editor on startup (#6861)
  Sort-in root classes into packages (#6853)
  Add "Fetchers" to DevDocs
Siedlerchr added a commit that referenced this pull request Sep 12, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into testEA15Adopt
784c025 
* upstream/master: (55 commits)
  Fix sort order in main table not stored (#6898)
  Window "Manage field names & content": make title consistent with menu (+ localization) (#6895)
  Complete rebranding of `bibtexkey` as `citationkey` (#6875)
  Dev-doc: ADR list (#6887)
  Bump lucene-queryparser from 8.6.1 to 8.6.2 (#6881)
  Bump fontbox from 2.0.20 to 2.0.21 (#6883)
  Bump org.beryx.jlink from 2.21.3 to 2.21.4 (#6882)
  Bump com.github.ben-manes.versions from 0.29.0 to 0.30.0 (#6884)
  Bump pdfbox from 2.0.20 to 2.0.21 (#6885)
  Bump mockito-core from 3.5.7 to 3.5.10 (#6886)
  lint changelog
  Dev Doc: Moving around ADR (end?) (#6873)
  Add MD031 to lint ignore list
  Add mlep's other email adress
  Fetch by ID: SAO/NASA Astrophysics Data System -> SAO/NASA ADS (#6876)
  Reimport -> Reload (#6874)
  GitBook: [master] 19 pages and 4 assets modified
  Add new author
  Delete .Rhistory
  Fix icon issue (#6858)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New DOI icon is confusing and inconsistent
4 participants
@fabiojavamarcos @DominikVoigt @calixtus @tobiasdiez