Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DOI icon is confusing and inconsistent #6834

Closed
DominikVoigt opened this issue Sep 1, 2020 · 5 comments · Fixed by #6858
Closed

New DOI icon is confusing and inconsistent #6834

DominikVoigt opened this issue Sep 1, 2020 · 5 comments · Fixed by #6858
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. ui

Comments

@DominikVoigt
Copy link
Contributor

The new icon used for DOIs is confusing since the chain icon is crossed out.
Furthermore, the DOI icon in the entries is inconsistent with the DOI icon in the header.

Suggestion: Either revert the icon back or use a normal chain icon.
Furthermore, make the DOI icon used in the header and entries consistent.

image

@Siedlerchr Siedlerchr added good first issue An issue intended for project-newcomers. Varies in difficulty. ui labels Sep 1, 2020
@Siedlerchr Siedlerchr added the bug Confirmed bugs or reports that are very likely to be bugs label Sep 1, 2020
@koppor
Copy link
Member

koppor commented Sep 2, 2020

Since this is an external link, the icon should be the normal link icon - not crossed out

@fabiojavamarcos
Copy link
Contributor

It seems the chain is crossed out when there is no information from the URL or the DOI. When the information is available, the chain is a regular one (not crossed out). Finally, when both are missing, no icon is shown. Is this behavior correct?

@mlep
Copy link
Contributor

mlep commented Sep 2, 2020

In JabRef 5.2:

  • the chain is crossed out when there is only one link identifier.
  • the chain is not crossed out when there are several link identifier.
  • no symbol when there is no link identifier

To me it looks fine, except for the crossed out chain: I do not understand the rationale.

@koppor
Copy link
Member

koppor commented Sep 2, 2020

Crossed out is crossed out. Thus, interpretation as "one" is strange.

Can we create a custom icon?

Alternative 1

  • chain with a small one - having one entry attached
  • chain with a small * - for more than one entry (or the real number of links showing)

Alternative 2

  • single chain - having one entry attached
  • two chains overlapping - having multiple links attached

Discusion

I am or alternative 2, because two same icons denote multiplicity

@fabiojavamarcos
Copy link
Contributor

For Alternative 2

  • single chain: there is an icon called "link" available immediately in the library.
  • two chains: keep the "link_variant" that has two chains overlapping.

Do you agree?

fabiojavamarcos added a commit to fabiojavamarcos/jabref that referenced this issue Sep 3, 2020
@fabiojavamarcos fabiojavamarcos mentioned this issue Sep 3, 2020
5 tasks
tobiasdiez pushed a commit that referenced this issue Sep 3, 2020
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants