Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE-fix for Preferences/Ext-Prog/Settings for X/Browse #4983

Merged
merged 11 commits into from
May 21, 2019
Merged

NPE-fix for Preferences/Ext-Prog/Settings for X/Browse #4983

merged 11 commits into from
May 21, 2019

Conversation

calixtus
Copy link
Member

Title should be self-explanatory, dialogservice was not initialized.
As it was working in 4.3.1, there is no need to put the fix in the Changelog.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

tobiasdiez
tobiasdiez requested changes May 19, 2019
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I've one suggestion for improvement, otherwise it looks good.

src/main/java/org/jabref/gui/push/PushToApplicationSettings.java Outdated Show resolved Hide resolved
@calixtus calixtus changed the title NPE-fix for Preferences/Ext-Prog/Settings for X/Browse [WIP] NPE-fix for Preferences/Ext-Prog/Settings for X/Browse May 19, 2019
@calixtus
Copy link
Member Author

calixtus commented May 19, 2019 •
edited
Loading

I realized, pushApplications is a static manager in JabRefFrame and I don't wonna change something on this big level. I tried a diffrent solution, using Constructors - as asked. It's been a bit tricky.
Thoughts?

@calixtus calixtus changed the title [WIP] NPE-fix for Preferences/Ext-Prog/Settings for X/Browse NPE-fix for Preferences/Ext-Prog/Settings for X/Browse May 19, 2019
@calixtus
Copy link
Member Author

Done a small identifier reword, to keep it consistent, should be ready to review now.

@Siedlerchr
Copy link
Member

Just one little further optimiation, but otherwise looks good and seems like the best solution so far.
Thanks for your contribution!

@calixtus calixtus force-pushed the fix-prefs-extp-set-browse branch from ec888f1 to c456701 Compare May 20, 2019 22:51
Siedlerchr
Siedlerchr approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now :)

@calixtus
Copy link
Member Author

Oh dear, that was kind of confusing... Never really worked with mixed static classes and instances of it.
But I am happy if it's fine now.

@Siedlerchr
Copy link
Member

@calixtus Yeah, I know. And this class is not really that easy to understand with the hierarchy and the dialogServie argument which is passed along. But glad you spotted and fixed the dialogService error. :)

I don't know how experienced you are with Java, but I can really recommend this book here, which is written by JabRef (ex) developers: https://www.amazon.com/Java-Comparison-Become-Craftsman-Examples/dp/1680502875

@calixtus
Copy link
Member Author

I studied computer science (Informatik) for one year in 2004-2005 in Passau and I had some Java lessons before I changed the subject of my studies, but it's way to long ago to remember all the details. I am doing this here in my leasure time.
Maybe i'm going to take a look into the book. Thank's for your advice.

tobiasdiez
tobiasdiez approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's looks perfect now. Thanks again!

@tobiasdiez tobiasdiez merged commit 9322cde into JabRef:master May 21, 2019
@calixtus calixtus deleted the fix-prefs-extp-set-browse branch May 21, 2019 12:21
Siedlerchr added a commit that referenced this pull request May 25, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into convertSearchWorker
858ffd8 
* upstream/master:
  Fix background color of dialogs in dark mode (#4994)
  NPE-fix for Preferences/Ext-Prog/Settings for X/Browse  (#4983)
  Bump richtextfx from 0.10.0 to 0.10.1 (#4989)
  Bump tika-core from 1.20 to 1.21 (#4984)
Siedlerchr added a commit that referenced this pull request May 26, 2019
@Siedlerchr
Merge branch 'ieeFix' of github.com:JabRef/jabref into ieeFix
62553de 
* 'ieeFix' of github.com:JabRef/jabref:
  Fix the 'Attach file' dialog for starting on the user's main directory (#4996)
  Readme TOC (#4986)
  Fix icon size - the second (#4993)
  Fix background color of dialogs in dark mode (#4994)
  NPE-fix for Preferences/Ext-Prog/Settings for X/Browse  (#4983)
  Bump richtextfx from 0.10.0 to 0.10.1 (#4989)
  Bump tika-core from 1.20 to 1.21 (#4984)
  Resize different fonts changing entry type (#4980)
  Extended Hints - Alternative to #4971 (#4975)
  Fix command line help text (#4979)
github-actions bot pushed a commit that referenced this pull request Aug 26, 2020
Squashed 'src/main/resources/csl-styles/' changes from 469deb6..93469bb
ad30687 
93469bb Create journal-of-musculoskeletal-research.csl (#4990)
43287c7 Update taxon.csl a little more (#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (#4982)
00c3cec Update isnad-metinici.csl (#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (#4983)
0c76011 Don't demote particles in Equine Vet J (#4984)
603ee73 Fix MLA editor translator (#4985)
40d207c Update pravnik.csl (#4986)
c5fe30c Update isnad-dipnotlu.csl (#4987)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 93469bb
github-actions bot pushed a commit to RamonG92/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
0d5ad2a 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to CaptainDaVinci/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
d721d0e 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to dimitra-karadima/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
d54dd55 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to Xuanxuan-Zou/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
eb015a2 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to felixbohnacker/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
f2e4e56 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to ShikunXiong/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
90ed62e 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to eetian/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
0c776a4 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to leitianjian/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
3ea0fd4 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to systemoperator/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
4a971d9 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to dextep/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
7c8e4e2 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to graffaner/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
95f1044 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to joe9111/jabref that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
763c60a 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to NikodemKch/jabref-1 that referenced this pull request Sep 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from eb0d37e..fad76fe
a88f1a1 
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixtus @Siedlerchr @tobiasdiez