Extended Hints - Alternative to #4971

[calixtus]

fixes #3599 - conflicts with #4971
I realized, talking about changes without presenting a possible solution is just lame.

What do you think?

Sorry about these ugly commit-msgs. I promise improvement.

---

• Change in CHANGELOG.md described
• Tests created for changes
• Manually tested changed features in running JabRef
• Screenshots added in PR description (for bigger UI changes)
• Ensured that the git commit message is a good one
• Check documentation status (Issue created for outdated help page at help.jabref.org?)

[calixtus]

Did some rewording according to the suggestion. I'll take a look into the source the next days to identify, what else could be a extended hint.

Suggestions are very welcome.

[calixtus]

Sorry about the force-push. I think i still dont have my git-environment set up right...

However, i tried to comletely seperate the logic about whats in the tooltip and about if it's visible or not, and to avoid unnecessary function calls as well. Thanks also to @davidemdot .

About the switchable visibility in the PreferencesDialog: im really not sure if i did this right, because i did not see another proper way to update the visibility. I tested it, it works fine, but is this intended?

[Siedlerchr]

About the switchable visibility in the PreferencesDialog: im really not sure if i did this right, because i did not see another proper way to update the visibility. I tested it, it works fine, but is this intended?

Not sure what you mean but codewise lgtm so far

[calixtus]

My question is about the call to "updateAfterPreferenceChanges();" in "storeAllSettings();" i put in. UpdateAfter was always called after resetting or importing any preference, but was not after saving and closing. I inserted the call there, but i don't really understand, if this is really the right place. I fear not. ;-)

[Siedlerchr]

Ah now I understand what you mean. Not it does not make sense to add it there, cause it will call setValues on each tab -> setting the values for the controls in all preferences tabs. Only useful after you reseted to default, so that all checkboxes etc show default values or after the import of new prefs so that the gui state reflects the prefs state.

When you save you don't need to set the values again, cause you already manually changed the gui states of the controls.

[Siedlerchr]

Lgtm now! Is this ready now?

[calixtus]

Yes, I would say so.
Although there are only two clues that can be hidden now - it is enough for a proof-of-concept.
Further hints can be added together with other pull requests.
Thanks for your feedback.

[tobiasdiez]

Thanks again!