Migrate to native gradle test task #3987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
added
the
status: ready-for-review
Siedlerchr
approved these changes
Apr 26, 2018
|
|
Otherwise looks reasonable. |
stefan-kolb
approved these changes
Apr 26, 2018
tobiasdiez
added
status: help wanted
and removed
status: ready-for-review
|
Some of the tests fail now...I've no idea why and sadly no time for further investigations in the next days. So any help is appreciated. |
|
Normally the XML order should not play a role. Maybe that's why they fail? Or is it because of some missing xsd file again`? |
|
I think these tests were actually failing before but were not executed before...now they are. |
|
I now found time to fix the tests. For some reason these tests were not executed before. It's strange and I couldn't find a pattern but since also the code coverage jumped by +2% (with almost +10% logic) it really proves that some tests were not executed. Since fixing these tests was straightforward and this PR already has two positive responses, I merge now. |
Siedlerchr
added a commit
that referenced
this pull request
May 5, 2018
…rsectionnew * upstream/maintable-beta: (88 commits) set look and feel to windows, aqua or nimbus for swing in case fix import remove look and feel New translations JabRef_en.properties (French) (#4009) Fix Look and Feel related issues (#4002) Fix statement in changelog [WIP] Add Text File Export for "Find Unlinked Files" (#3979) Fix IEEE preview does not display month (#3983) Activate context menu on key press (#4004) Improve code layout Fix concurrent modification exception when adding entries to groups Fix build Typo Add fix Rename test Fix #3994 Duplicate unmodifiable list for sorting (#3996) Remove deprecated and unused method (#3993) Improvements around external file types (#3887) Migrate to native gradle test task (#3987) Do not run checkstyle as part of the gradle check task (#3985) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JabRef#318.