Do not run checkstyle as part of the gradle check task #3985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
added
the
status: ready-for-review
Siedlerchr
reviewed
Apr 26, 2018
| - TEST_SUITE=check OPTIONS=modernizer | ||
| - TEST_SUITE=checkstyle |
There was a problem hiding this comment.
I would definitely execute checkstyle first. As it will always fail asap. So you already know that you have to fix this again
There was a problem hiding this comment.
They are not guaranteed to run in the specified order (but are started at almost the same time anyway in most cases). Thus it is more a display thing, and the main build is definitely the more important one.
stefan-kolb
approved these changes
Apr 26, 2018
Siedlerchr
added a commit
that referenced
this pull request
May 5, 2018
…rsectionnew * upstream/maintable-beta: (88 commits) set look and feel to windows, aqua or nimbus for swing in case fix import remove look and feel New translations JabRef_en.properties (French) (#4009) Fix Look and Feel related issues (#4002) Fix statement in changelog [WIP] Add Text File Export for "Find Unlinked Files" (#3979) Fix IEEE preview does not display month (#3983) Activate context menu on key press (#4004) Improve code layout Fix concurrent modification exception when adding entries to groups Fix build Typo Add fix Rename test Fix #3994 Duplicate unmodifiable list for sorting (#3996) Remove deprecated and unused method (#3993) Improvements around external file types (#3887) Migrate to native gradle test task (#3987) Do not run checkstyle as part of the gradle check task (#3985) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, the
checkstyletask is no longer invoked as part of thebuildorchecktask. ThecheckstyleMaintask and its variations are kept.Reason: The build fails as soon as the checkstyle task fails, possibly hiding more important build or test failures (recent example). Moreover, the checkstyle task is invoked as a separate build command on travis anyway.