Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save order of columns across sessions #3783

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Conversation

tobiasdiez
Copy link
Member

After the user reorder the columns of the maintable per drag and drop, these changes are now saved in the preferences. Moreover, I refactored a bit how preferences are loaded from the global preferences class.


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 27, 2018

/*** end: special fields ***/

static class TableRow {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why this has to be static?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea... (the code quality in the preferences tabs is so bad anyway).

Copy link
Member

@Siedlerchr Siedlerchr Feb 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally see to reason to have this whole column stuff in the preferences tab anylonger. I think it was only added because we could not save the column reordering the user did directly on the maintable. I would vote to remove that stuff completely.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, currently, this is the only place where you can choose which columns are shown.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not adding a table column selector like it's possible in nearly every table

grafik

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea! I have to think a bit more about it and how to make it work for JabRef (we allow also columns of the form author/editor and have to many fields to display them all in a drop down - possible a combination of drop down and text field may work). But not as part of this PR.

@Siedlerchr
Copy link
Member

Can I still change the order and width in the settings?

@tobiasdiez
Copy link
Member Author

@Siedlerchr Yes, this should still work.

@Siedlerchr Siedlerchr merged commit d8914a8 into maintable-beta Feb 27, 2018
@Siedlerchr Siedlerchr deleted the fixRememberColumns branch February 27, 2018 17:28
Siedlerchr added a commit that referenced this pull request Feb 27, 2018
…gsjavafx

* upstream/maintable-beta:
  Save order of columns across sessions (#3783)
  Allow side pane to be completely hidden (#3784)
  Show empty group pane if no database is open (#3785)
  Reenable drag'n'drop support for tabs / libraries (#3688)
Siedlerchr added a commit that referenced this pull request Feb 28, 2018
…drop

* upstream/maintable-beta:
  Save order of columns across sessions (#3783)
  Allow side pane to be completely hidden (#3784)
  Show empty group pane if no database is open (#3785)
  Reenable drag'n'drop support for tabs / libraries (#3688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants