-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save order of columns across sessions #3783
Conversation
|
||
/*** end: special fields ***/ | ||
|
||
static class TableRow { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why this has to be static?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea... (the code quality in the preferences tabs is so bad anyway).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally see to reason to have this whole column stuff in the preferences tab anylonger. I think it was only added because we could not save the column reordering the user did directly on the maintable. I would vote to remove that stuff completely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, currently, this is the only place where you can choose which columns are shown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is an example https://gist.github.com/Roland09/d92829cdf5e5fee6fee9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good idea! I have to think a bit more about it and how to make it work for JabRef (we allow also columns of the form author/editor
and have to many fields to display them all in a drop down - possible a combination of drop down and text field may work). But not as part of this PR.
Can I still change the order and width in the settings? |
@Siedlerchr Yes, this should still work. |
After the user reorder the columns of the maintable per drag and drop, these changes are now saved in the preferences. Moreover, I refactored a bit how preferences are loaded from the global preferences class.