Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable drag'n'drop support for tabs / libraries #3688

Merged
merged 3 commits into from
Feb 26, 2018
Merged

Reenable drag'n'drop support for tabs / libraries #3688

merged 3 commits into from
Feb 26, 2018

Conversation

tobiasdiez
Copy link
Member

@tobiasdiez tobiasdiez commented Feb 3, 2018 •
edited
Loading

Use library DnDTabPane to reenable support for drag'n'drop to reorder open files.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@Siedlerchr
Copy link
Member

A native solution is avaiable with JDK 10: https://bugs.openjdk.java.net/browse/JDK-81870747
Further features (e.g. dragging to another tab pane or to a non fx thing will be avaiable in version 11:
https://bugs.openjdk.java.net/browse/JDK-8092098

@tobiasdiez tobiasdiez changed the title [WIP] Reenable drag'n'drop support for tabs Reenable drag'n'drop support for tabs / libraries Feb 26, 2018
@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 26, 2018
@tobiasdiez
Copy link
Member Author

This PR is now ready for review.

@Siedlerchr Siedlerchr merged commit 2999474 into maintable-beta Feb 26, 2018
@Siedlerchr Siedlerchr deleted the dragDropReorderTabs branch February 26, 2018 19:03
Siedlerchr added a commit that referenced this pull request Feb 27, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/maintable-beta' into editStrin…
f1e4cd8 
…gsjavafx

* upstream/maintable-beta:
  Save order of columns across sessions (#3783)
  Allow side pane to be completely hidden (#3784)
  Show empty group pane if no database is open (#3785)
  Reenable drag'n'drop support for tabs / libraries (#3688)
Siedlerchr added a commit that referenced this pull request Feb 28, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/maintable-beta' into fixdragan…
262e0c9 
…drop

* upstream/maintable-beta:
  Save order of columns across sessions (#3783)
  Allow side pane to be completely hidden (#3784)
  Show empty group pane if no database is open (#3785)
  Reenable drag'n'drop support for tabs / libraries (#3688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasdiez @Siedlerchr