Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to disable autocompletion in the search bar #3600

Merged
merged 2 commits into from
Jan 3, 2018

Conversation

lenhard
Copy link
Member

@lenhard lenhard commented Jan 3, 2018

Fixes #3598 by covering the autocompletion in the search bar with the same preference option as in the entry editor.


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@lenhard lenhard added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 3, 2018
@LinusDietz LinusDietz merged commit 193bbbc into master Jan 3, 2018
@LinusDietz LinusDietz deleted the search-AutoCompletePreferences branch January 3, 2018 19:41
@halirutan halirutan self-requested a review January 4, 2018 05:18
Siedlerchr added a commit that referenced this pull request Jan 9, 2018
* upstream/master: (40 commits)
  CleanupStep.MOVE_PDF is not a CleanupPreset anymore
  Add link and fix casing
  Explicitly set jacoco version (#3617)
  Update gradle from 4.4 to 4.4.1
  Update bcprov-jdk15on from 1.58 -> 1.59
  Fix NPE when changing entries between databases
  Add exporter desc to enum analog to import (#3606)
  Create 0001-use-crowdin-for-translations.md
  [ci skip] Get more Open Source Helpers (#3601)
  Update dependencies (#3602)
  Lookup filetypes in enum set to prevent NPE due to uninitialized expo… (#3597)
  Make it possible to disable autocompletion in the search bar (#3600)
  New translations JabRef_en.properties (Chinese Simplified)
  New translations JabRef_en.properties (French)
  New translations JabRef_en.properties (German)
  New translations JabRef_en.properties (Indonesian)
  New translations JabRef_en.properties (Italian)
  New translations JabRef_en.properties (Japanese)
  New translations JabRef_en.properties (Russian)
  New translations JabRef_en.properties (Spanish)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants