Lookup filetypes in enum set to prevent NPE due to uninitialized expo…

[Siedlerchr]

…rterFactory

Fixes #3596

This is my initial idea. Maybe we can optimize this

---

• Change in CHANGELOG.md described
• Tests created for changes
• Screenshots added (for bigger UI changes)
• Manually tested changed features in running JabRef
• Check documentation status (Issue created for outdated help page at help.jabref.org?)
• If you changed the localization: Did you run gradle localizationUpdate?

[tobiasdiez]

Sorry for introducing this bug and thanks for the quick fix. The solution you provide works but I think we can push it a bit further:

• the methods
  

  jabref/src/main/java/org/jabref/preferences/CustomExportList.java

  Line 107 in bf73b6f

  public void addFormat(List<String> s, LayoutFormatterPreferences layoutPreferences, SavePreferences savePreferences) {

  
  

  jabref/src/main/java/org/jabref/preferences/CustomExportList.java

  Line 90 in bf73b6f

  private Optional<TemplateExporter> createFormat(List<String> s, LayoutFormatterPreferences layoutPreferences,

  
  can be improved by not using a List<String> array but just a normal list of three arguments.
• The code to determine the FileType from the string should already happen here:
  

  jabref/src/main/java/org/jabref/gui/exporter/CustomExportDialog.java

  Lines 198 to 207 in d381839

  	public String extension() {
  	String ext = extension.getText();
  	if (ext.startsWith(".")) {
  	return ext;
  	} else if (ext.startsWith("*.")) {
  	return ext.substring(1);
  	} else {
  	return '.' + ext;
  	}
  	}

  
  so that the rest of the code uses FileType and not a string.
• the conversion string -> FileType should probably be moved to a static method parse in FileType.

May I ask you to do these further refactoring? Thanks!

[lenhard]

Code-wise, I have nothing to add to @tobiasdiez comments.

I have also executed the branch locally and JabRef starts up as expected.

[Siedlerchr]

I refactored the list where possible. This can be further improved if this rather simple dialog is ported to javafx (for example, getting rid of the glazedcel EventListl dependency)

[tobiasdiez]

Thanks!