Fix DOI resolving by using https #2889
Conversation
Siedlerchr
added
the
status: ready-for-review
CHANGELOG.md
Outdated
| @@ -26,6 +26,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `# | |||
| - We added integration of the Library of Congress catalog as a fetcher based on the [LCCN identifier](https://en.wikipedia.org/wiki/Library_of_Congress_Control_Number). [Feature request 636 in the forum](http://discourse.jabref.org/t/loc-marc-mods-connection/636) | |||
|
|
|||
| ### Fixed | |||
| - We fixed the adding of a new entry from DOI which led to a connection error [#2879](https://github.com/JabRef/jabref/issues/2897) | |||
There was a problem hiding this comment.
Suggestion: Improve wording to make clear that now HTTPS is used to protect the privacy of the user.
* upstream/master: Fix DOI resolving by using https (#2889) Adjust tests: Ads fetcher returns url, DBLP no longer works with negative operators (#2891) Fix loading of preferencesService (#2882) Add link to "feature branch workflow" Support Annotations Created by Foxit (#2878) Fixes jacoco by excluding the fetcher tests from analysis (#2877) # Conflicts: # src/main/java/org/jabref/gui/DefaultInjector.java
ghost
mentioned this pull request
* Fix DOI resolving by using https * Add changelog * Fix DOI layout test * Reword changelog # Conflicts: # CHANGELOG.md # src/main/java/org/jabref/model/entry/identifier/DOI.java # src/test/java/org/jabref/logic/layout/format/DOICheckTest.java # src/test/java/org/jabref/model/entry/identifier/DOITest.java
|
Any binairie install plane? I can't create mine from jabref.install4j because i need a 'Windows key store'. I don't get what it means but I really need this update. |
|
This fix is already part of 4.0-beta2 or the recent Dev builds which can be downloaded here: https://builds.jabref.org/master So you don't need to build JabRef on your own. Best, |
|
Thanks for your (amazing) fast answer. Thanks :) |
|
We are very interested on a 3.8.3 version for Gentoo too. |
|
I don't think we will release a 3.8.3. The only active branch and release version will be 4.x. |
|
Is there a special reason for that? It does not seem that the 4.x tree will have the stability of 3.8.x in the near future. We have many users who were interested in working on 3.8.2, but need doi. We provide 4.x now for the interested hacker on Gentoo with every new snapshot. But for now for example the snapshot is very broken and 4.0 release freezes when dragging to a group. |
|
Resources, ancient & hard to maintain technology. |
|
@jonasstein Regarding the freeze when dragging to a group, one thing just came to my mind: What is the look and feel you are using? We had a few Linux users who experienced freezes with the GTK look and feel. Switching to a different look and feel (e.g. plastic) effectively solved their problem. Does that maybe also help in your case? If so, the trivial solution would be to set a different default look and feel on Linux. Maybe the solution is also too hidden in the documentation: https://help.jabref.org/en/Installation#freezes-when-running-jabref |
|
It was this one: Which is gtk? I would love a real classic gtk look. The "modern" design may look interesting but are not so ergonomic for office work in my opinion. |
|
Ok, too bad. Thanks for testing! |
Fix for #2879
I think this is an important issue with small code change. @JabRef/developers Should we do a fix for 3.8,2?
For 3.8.2 https://github.com/JabRef/jabref/blob/v3.8.2/src/main/java/net/sf/jabref/logic/util/DOI.java
- [ ] Screenshots added (for bigger UI changes)- [ ] Check documentation status (Issue created for outdated help page at [help.jabref.org](https://github.com/JabRef/help.jabref.org/issues)?)- [ ] If you changed the localization: Did you rungradle localizationUpdate?