Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading of preferencesService #2882

Merged
merged 1 commit into from
Jun 4, 2017
Merged

Fix loading of preferencesService #2882

merged 1 commit into from
Jun 4, 2017

Conversation

Siedlerchr
Copy link
Member

The else part tried to instantiate the interface otherwise
Fix for #2881

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@Siedlerchr
Fix loading of preferencesService
eab33af 
The else part tried to instantiate the interface otherwise
@Siedlerchr Siedlerchr requested a review from tobiasdiez June 3, 2017 10:45
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 3, 2017
LinusDietz
LinusDietz approved these changes Jun 3, 2017
View reviewed changes
Copy link
Member

@LinusDietz LinusDietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@lenhard lenhard merged commit abfb941 into master Jun 4, 2017
@lenhard lenhard deleted the fixPreferenceLoading branch June 4, 2017 14:45
@lenhard lenhard mentioned this pull request Jun 4, 2017
Closed
Siedlerchr added a commit that referenced this pull request Jun 6, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into sharelatex
f7c9c61 
* upstream/master:
  Fix DOI resolving by using https (#2889)
  Adjust tests: Ads fetcher returns url, DBLP no longer works with negative operators (#2891)
  Fix loading of preferencesService (#2882)
  Add link to "feature branch workflow"
  Support Annotations Created by Foxit (#2878)
  Fixes jacoco by excluding the fetcher tests from analysis (#2877)

# Conflicts:
#	src/main/java/org/jabref/gui/DefaultInjector.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenhard lenhard lenhard approved these changes

@LinusDietz LinusDietz LinusDietz approved these changes

@tobiasdiez tobiasdiez Awaiting requested review from tobiasdiez

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Siedlerchr @LinusDietz @lenhard