Update openrewrite #10782
Closed
Update openrewrite #10782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koppor
added
dev: code-quality
|
The build of this PR is available at https://builds.jabref.org/pull/10782/merge. |
|
fails |
calixtus
approved these changes
Jan 14, 2024
|
like the approach, but the new rewrite also seems buggy |
|
I was hoping that magically it would be fixed. -- Need to be patient until the fix for openrewrite/rewrite#3913 appears in a release. |
koppor
removed
the
status: ready-for-review
|
Follow-up PR: #10813. There, the fix is included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newer openRewrite is more aggressive in removing braces. Hope, you like it.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)