Assignments inside condition do not work with Parenthesis removal

[koppor]

I updated openrewrite:

-    id 'org.openrewrite.rewrite' version '6.6.3'
+    id 'org.openrewrite.rewrite' version '6.6.6'

-    rewrite(platform("org.openrewrite.recipe:rewrite-recipe-bom:2.5.4"))
+    rewrite(platform("org.openrewrite.recipe:rewrite-recipe-bom:2.6.1"))

Some more parentheses are removed here.

I have some WTF parts in the code with assignments inside (!) if conditions. When removing parentheses here, it leads to a compiler error

-        if ((str == null) || ((end = str.length()) == 0) || ((((ch = str.charAt(0)) < '0') || (ch > '9')) && (!(sign = ch == '-') || (++idx == end) || ((ch = str.charAt(idx)) < '0') || (ch > '9')))) {
+        if ((str == null) || ((end = str.length()) == 0) || ((((ch = str.charAt(0)) < '0') || (ch > '9')) && (!sign = ch == '-' || (++idx == end) || ((ch = str.charAt(idx)) < '0') || (ch > '9')))) {

C:\git-repositories\jabref-all\jabref\src\main\java\org\jabref\model\strings\StringUtil.java:486: error: unexpected type
        if ((str == null) || ((end = str.length()) == 0) || ((((ch = str.charAt(0)) < '0') || (ch > '9')) && (!sign = ch == '-' || (++idx == end) || ((ch = str.charAt(idx)) < '0') || (ch > '9')))) {
                                                                                                              ^
  required: variable
  found:    value

[timtebeek]

Hi @koppor ; Thanks for the report! It seems we're not yet handling that !(sign = ch == '-') correctly in

rewrite/rewrite-java/src/main/java/org/openrewrite/java/cleanup/UnnecessaryParenthesesVisitor.java

Line 27 in 7d3655a

public class UnnecessaryParenthesesVisitor<P> extends JavaVisitor<P> {

I'll move this issue and we can fix that in openrewrite/rewrite.

[koppor]

Thank you for moving around. I still have not (fully) learned in which repository which issue should go. I really praise GitHub that it implemented the move-around-feature!

---

The code in question came from http://stackoverflow.com/questions/1030479/most-efficient-way-of-converting-string-to-integer-in-java

[timtebeek]

I understand it's sometimes not immediately clear where issues should be reported or fixed; You're right in reporting issues in the repository are located, and I'll move the issues where I think the fix might be elsewhere as it was here. Thanks again for the report; really helpful, and this case quickly fixed with 670dd5c

[koppor]

I can confirm that the fix works in the BOM 2.6.2 - JabRef/jabref#10813

[timtebeek]

Glad to hear, thanks! Always nice to get that feedback. :)