Issue 10431 relevance star

[LenkaBuebnkova]

A relevance field was modified so it can no longer be visible upon hovering as it was causing confusion regarding the actual value of selected entry. It has been modified so a new menu appears upon clicking on the "Relevance" field of a selected entry with a selection of 2 options to set it to - Set as Relevant / Set as Irrelevant. Upon choosing one of the mentioned options, the selected entry will be then marked / unmarked with the star icon based by the chosen option. Adding a menu option for "Relevance" was to maintain visual consistency with the existing menu options for special fields such as "Read" and "Priority." Basic tests were also created for this.

Resolves #10431

Mandatory checks

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[ThiloteE]

To ease organizational workflows I have linked the pull-request to the issue with syntax as described in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Linking a pull request to an issue using a keyword

You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message. The pull request must be on the default branch.

• close
• closes
• closed
• fix
• fixes
• fixed
• resolve
• resolves
• resolved

If you use a keyword to reference a pull request comment in another pull request, the pull requests will be linked. Merging the referencing pull request also closes the referenced pull request.

The syntax for closing keywords depends on whether the issue is in the same repository as the pull request.

Example:

• ✅ Fix #xyz links pull-request to issue. Merging the PR will close the Issue.
• ✅ Fix https://github.com/JabRef/jabref/issues/xyz links pull-request to issue. Merging the PR will close the Issue.
• ✅ Fix https://github.com/Koppor/jabref/issues/xyz links pull-request to issue. Merging the PR will close the Issue.
• ❌ Fix [#xyz](https://github.com/JabRef/jabref/issues/xyz) links pull-request to issue. Merging the PR will NOT close the Issue.

[ryan-carpenter]

The proposed solution would change what is currently a simple toggle into a two-click operation, making this convenient feature harder to use. The main issue is that the star appears on row selection, even when the entry is not relevant. This creates an opportunity for confusion before I hover or click on the star. Confusion related to hovering or clicking (on the star) occurs mainly because of the row selection and not because of the hover or click.

[LenkaBuebnkova]

I have also solution for the hovering, I will upload my solution without menu part.

[LenkaBuebnkova]

Solution of issue with icon showing while hovering is fixed and uploaded changes in one file are pushed.

[Siedlerchr]

I didn't see any new code? Did you push your changes because now the diff shows no changes

[LenkaBuebnkova]

Hi, changes were done in the firsts commits, changed file is in tab Files changed - https://github.com/JabRef/jabref/pull/10620/files , more specifically, I have changed file MainTable.css where I deleted rows that created the issue.

[Siedlerchr]

Ah okay I see! I will test it later

[koppor]

We had a longer discussion and refined the intended solution for the issue #10431 (comment)

Unfortunately, this is different from yours. Thus, we close this PR.

The fix was to add the "right" CSS class.

+    -fx-icon-color: -jr-gray-2;

I found it while browsing through /src/main/java/org/jabref/gui/icon/InternalMaterialDesignIcon.java#L42 (org.jabref.gui.icon.InternalMaterialDesignIcon#getGraphicNode).