-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relevance star should only appear when toggled #10431
Comments
Hi, I would like to try to solve this issue, if it's possible :) |
As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at. Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback. |
Thanks, @LenkaBuebnkova |
The BibTeX source shows |
Hello, I'd appreciate a more comprehensive explanation. While I grasp the general idea, I'm struggling to pinpoint the specific section of the code responsible for setting the 'RELEVANCE' value. Could you kindly assist me in locating this information? |
@LenkaBuebnkova I think, maybe the code is somewhere in org.jabref.gui.maintable.columns.SpecialFieldColum. I currently do not see where the actual data is filled. You need to read the code. Note that you can search for an arbitrary string in the code using Ctrl+Shift+F. Maybe that helps to locate some code. |
I can reproduce. The issue is that we treat toggle fields differently than fields with more than one value. Long ago, we decided that it has to be possible to quickly change the state. We did not want to distinguish between
@Article{,
priority = {prio1},
readstatus = {read},
relevance = {relevant},
} and @Article{,
priority = {prio1},
readstatus = {read},
} We are aware that this cases huge diffs if changing that state, but we accept it in favor of a smaller BibTeX file. One sees that we use the same color for "relevant" and for "toggle relevance" (on hover). This is not an issue for the read status, because we use colors if set. There is not a consistency between the contents for the star-ratings (1 to 5 stars if set - all unset stars are gray) and the hover for the other fields. We do not want to do a deep change to relevance (e.g., introducing slightly relevant, relevant, highly relevant), but keep as is. We do following:
Fix: Color the icons to the colors of the five gray stars (instead of the black). Hoping that the user can distinguish gray from black. |
When the
Relevance (Special)
column is shown in the entry table and the relevance of an entry isfalse
, hovering over the entry makes a star appear in that column, regardless of the actual value. This makes it hard to identify and select the intended value, because relevance always appearstrue
for the entry under the cursor. For instance, clicking with the intention of removing the star when relevance is alreadyfalse
will set it totrue
(opposite of the intended result).The relevance status should be discernable regardless of hovering state.
Possible solutions
true
false
JabRef 5.10--2023-09-01--779e555
Linux 6.4.12-1-default amd64
Java 21-internal
JavaFX 20+19
The text was updated successfully, but these errors were encountered: