Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Windows binaries earlier #10402

Merged
merged 64 commits into from
Sep 21, 2023
Merged
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
329b3de
Upload Windows binaries earlier
koppor Sep 19, 2023
67e6ed2
Refine job name
koppor Sep 19, 2023
ec7069e
Try plain rsync
koppor Sep 19, 2023
a5fee7e
I hope, I got the right place now
koppor Sep 19, 2023
f6f5087
Fix "echo" vs. "cat"
koppor Sep 19, 2023
fb3093c
Install rsync on Windows
koppor Sep 19, 2023
30b7c18
Remove non-working "set -e"
koppor Sep 19, 2023
9b0f7ad
Debug
koppor Sep 19, 2023
1689bba
Fix argument
koppor Sep 19, 2023
e1d6c1a
Remove outdated checks
koppor Sep 19, 2023
e27deb0
Fix path
koppor Sep 19, 2023
9c8e3d3
Try different rsync on Windows
koppor Sep 19, 2023
ebb86af
Fix path
koppor Sep 19, 2023
4cf4a8f
Try it live
koppor Sep 19, 2023
6416a36
Merge jobs
koppor Sep 19, 2023
a37430d
Fix host key checking on macOS upload
koppor Sep 19, 2023
c37d2b4
Reuse information from previous job
koppor Sep 19, 2023
7a0ff36
Announce available builds earlier
koppor Sep 19, 2023
82f7e26
Generate journal-list.mv file only if necessary
koppor Sep 19, 2023
915413f
Merge jlinkZip and jpackage calls
koppor Sep 19, 2023
ee5ec93
Merge branch 'main' into speed-up-deployment
koppor Sep 19, 2023
36511c0
Add workaround for badass issue
koppor Sep 19, 2023
803b396
Fix dependency
koppor Sep 19, 2023
8acbe00
Fix dependency
koppor Sep 19, 2023
8019928
Fix condition
koppor Sep 19, 2023
67b0abf
Remove output (causes issues and does not speed up)
koppor Sep 19, 2023
2403af9
Fix casing
koppor Sep 19, 2023
75e6d7c
Comment on PR after *all* builds are uploaded
koppor Sep 19, 2023
db58f46
Try better condition for notarization
koppor Sep 19, 2023
cae9c42
macOS: Upload only one version
koppor Sep 19, 2023
368a810
Use most recent rsync on macOS
koppor Sep 20, 2023
4d333a4
Use GuillaumeFalourd/setup-rsync
koppor Sep 20, 2023
8a70222
Put OS as first in the overview
koppor Sep 20, 2023
2f3f020
Refine step names
koppor Sep 20, 2023
e5f231e
Test new setup rsync
koppor Sep 20, 2023
eec8148
Fix debug
koppor Sep 20, 2023
df62a79
Try other ssh key location
koppor Sep 20, 2023
adeaf8b
Try other shell
koppor Sep 20, 2023
2e0190d
Try ~/sshkey as path
koppor Sep 20, 2023
84f15b2
Revert "Use GuillaumeFalourd/setup-rsync"
koppor Sep 20, 2023
c8aecd2
Merce linux and macos (by smartly merging the conditions
koppor Sep 20, 2023
fc10a8a
Simplify conditions
koppor Sep 20, 2023
512fc24
Try to fix condition
koppor Sep 20, 2023
4483a1b
Try to apply https://maxschmitt.me/posts/github-actions-ssh-key (and …
koppor Sep 20, 2023
61f8f1f
Try runner.temp for ssh key
koppor Sep 20, 2023
bd5ec11
Debug conditions
koppor Sep 20, 2023
0aa935c
Try to debug on Windows, too
koppor Sep 20, 2023
acb341e
Disable large workflow until tests succeed
koppor Sep 20, 2023
7a6fad8
WTF GitHub
koppor Sep 20, 2023
bc44e76
Some more debug
koppor Sep 20, 2023
1368a8f
Remove debug
koppor Sep 20, 2023
73cd78e
Fix condition
koppor Sep 20, 2023
8dbd3f1
Try mixed slashes
koppor Sep 20, 2023
ae34117
Try some slash replacement
koppor Sep 20, 2023
3ef2052
Fix quotes
koppor Sep 20, 2023
1fa9d2f
Remove debug
koppor Sep 20, 2023
c8487a0
rsync setup only if required
koppor Sep 20, 2023
7b1997d
Fix casing
koppor Sep 20, 2023
cfb5ac6
We don't need --partial
koppor Sep 20, 2023
4b3375e
Replace -Pavz by -rt (because we do not need full ownership transfer …
koppor Sep 20, 2023
7fbf77d
Revert "Replace -Pavz by -rt (because we do not need full ownership t…
koppor Sep 20, 2023
d303ba7
Revert "Revert "Replace -Pavz by -rt (because we do not need full own…
koppor Sep 20, 2023
9be1a13
Need to fix permissions at the target side (Windows)
koppor Sep 20, 2023
406b451
Merge branch 'main' into speed-up-deployment
calixtus Sep 21, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions .github/workflows/deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -232,15 +232,12 @@ jobs:
mv -f jabref_${{ steps.gitversion.outputs.Major }}.${{ steps.gitversion.outputs.Minor }}_amd64_repackaged.deb jabref_${{ steps.gitversion.outputs.Major }}.${{ steps.gitversion.outputs.Minor }}_amd64.deb
- name: Upload to builds.jabref.org (ubuntu, Windows)
if: ((matrix.os == 'ubuntu-latest') || (matrix.os == 'windows-latest')) && (steps.checksecrets.outputs.secretspresent == 'YES') && (!startsWith(github.ref, 'refs/heads/gh-readonly-queue'))
uses: Pendect/[email protected]
env:
DEPLOY_KEY: ${{ secrets.buildJabRefPrivateKey }}
with:
flags: -vaz --itemize-changes --stats --partial-dir=/tmp/partial --rsync-path="mkdir -p /var/www/builds.jabref.org/www/${{ steps.gitversion.outputs.branchName }} && rsync"
options: ''
ssh_options: '-p 9922'
src: 'build/distribution/'
dest: [email protected]:/var/www/builds.jabref.org/www/${{ steps.gitversion.outputs.branchName }}/
shell: bash
run: |
set -e
mkdir -p ~/.ssh
cat "${{ secrets.buildJabRefPrivateKey }}" > ~/.ssh/id_rsa
rsync -Pavz --itemize-changes --stats --partial-dir=/tmp/partial --rsync-path="mkdir -p /var/www/builds.jabref.org/www/${{ steps.gitversion.outputs.branchName }} && rsync" -e 'ssh -p 9922 -i ~/.ssh/id_rsa' build/distribution/ [email protected]:/var/www/builds.jabref.org/www/${{ steps.gitversion.outputs.branchName }}/
koppor marked this conversation as resolved.
Show resolved Hide resolved
- name: Upload to GitHub workflow artifacts store (macOS)
if: (matrix.os == 'macos-latest') && (steps.checksecrets.outputs.secretspresent == 'YES') && (!startsWith(github.ref, 'refs/heads/gh-readonly-queue'))
uses: actions/upload-artifact@v3
Expand Down