Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Windows binaries earlier #10402

Merged
merged 64 commits into from
Sep 21, 2023
Merged

Upload Windows binaries earlier #10402

merged 64 commits into from
Sep 21, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Sep 19, 2023

The CI runs very long. I checked. The Windows binaries can be uploaded at the same point in time as the Linux binaries.

Additonally:

  • fix casing macOS (I hope, the last one)
  • remove obsolete step (we had a non-macOS step in macOS notarization part)
  • remove obsolete spaces

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor marked this pull request as draft September 19, 2023 18:52
@koppor
Copy link
Member Author

koppor commented Sep 20, 2023

  • After merge, the branch protection rules need to be updated. I renamed "
    Create installer and portable version for linux" to "linux installer and portable version" (because I wanted to have the OS displayed in the graphical view)

@koppor
Copy link
Member Author

koppor commented Sep 20, 2023

Current timings:

image

@koppor
Copy link
Member Author

koppor commented Sep 20, 2023

With notarization:

image

Files available at https://builds.jabref.org/speed-up-deployment/

@koppor koppor marked this pull request as ready for review September 20, 2023 12:49
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 20, 2023
@calixtus
Copy link
Member

Looks fine to me, works, so ...

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor merged commit b9df9cb into main Sep 21, 2023
@koppor koppor deleted the speed-up-deployment branch September 21, 2023 07:17
@koppor
Copy link
Member Author

koppor commented Sep 21, 2023

To track: Build of a fork - with empty cache:

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants