Install chrome extension automatically

[tobiasdiez]

It would be nice if the Chrome extension would be automatically installed during the main installation routine.

Shouldn't be that hard to implement: https://developer.chrome.com/extensions/external_extensions
@LyzardKing interested? 😄

(For Firefox something like this is sadly not supported: https://blog.mozilla.org/addons/2019/10/31/firefox-to-discontinue-sideloaded-extensions/)

[koppor]

If Firefox is installed: Open JabRef extension page in firefox store.

[koppor]

@LyzardKing Ping? 😇

[calixtus]

Firefox download page would be something like
https://addons.mozilla.org/de/firefox/addon/jabref/?src=search

[LyzardKing]

I'll have a look at it! I don't have too much time, but I'll see what I can do :)

[LyzardKing]

Ok.. I have the correct file, and it works on Chrome.
We need to set a trigger to copy the file in the correct folder (creating it if it doesn't exist).
This can be done on a non snap browser easily with sudo credentials.
Should this be part of the deb install? I can add to the postinstall trigger there.

[LyzardKing]

The macos part should be the same.. I can test that easily.
The windows implementations requires editing the registry. I have no idea how to do that (my last windows machine was windows 98 a while back) but I'm willing to try if you have any suggestion!

[tobiasdiez]

Perfect. Thanks a lot @LyzardKing!

Yes, the idea was to add these steps to the installation routines as post-actions. For Windows, adding a line similar to

jabref/buildres/windows/JabRef-post-image.wsf

Line 24 in 3bc1f02

contents = contents.replace("</Product>", "<DirectoryRef Id=\"TARGETDIR\"><Component Id=\"RegistryJabRefBrowserEntries\" Guid=\"b6bc55ad-905c-4258-89b1-8b37abbe559c\" Win64=\"yes\"><RegistryKey Root=\"HKMU\" Key=\"SOFTWARE\\Mozilla\\NativeMessagingHosts\\org.jabref.jabref\" Action=\"createAndRemoveOnUninstall\" ForceCreateOnInstall=\"yes\"><RegistryValue Type=\"string\" Value=\"[INSTALLDIR]jabref.json\"/></RegistryKey><RegistryKey Root=\"HKMU\" Key=\"Software\\Google\\Chrome\\NativeMessagingHosts\\org.jabref.jabref\" Action=\"createAndRemoveOnUninstall\" ForceCreateOnInstall=\"yes\"><RegistryValue Type=\"string\" Value=\"[INSTALLDIR]jabref-chrome.json\"/></RegistryKey></Component></DirectoryRef><Feature Id=\"BrowserExtension\" Level=\"1\"><ComponentRef Id=\"RegistryJabRefBrowserEntries\" /></Feature></Product>");

should work. I can also have a look at the Windows stuff.

[LyzardKing]

I opened a branch to test this out.. I only added the postinst/postrm scripts, but I'll start from there.
@tobiasdiez I'll try the windows integration!
I still have to look at the macos implementation in jpackage

[LyzardKing]

@tobiasdiez
In https://developer.chrome.com/extensions/external_extensions it seems like the current settings should not work in 64bit versions of windows..

Find or create the following key in the registry:

32-bit Windows: HKEY_LOCAL_MACHINE\Software\Google\Chrome\Extensions
64-bit Windows: HKEY_LOCAL_MACHINE\Software\Wow6432Node\Google\Chrome\Extensions

Am I missing something or should the .wsf be changed? At the moment it only seems to access the 32 bit folders..

[koppor]

@LyzardKing May I ask about an update? 😇

[LyzardKing]

Yes sorry...
The linux part seems to work (in the deb...)
I need to test it in a clean vm, but I plan to do that later today.
Regarding the windows part I'm waiting for a reply on the previous comment,regarding 32/64bit paths in regex.
The snap is up next, but the issue is that we should ask for more permissions, and in #6353 the issue of whether to ask for classic (unconfined) snap would be better, to enable the different integrations.
I cannot find (and I unfortunately haven't had too much time to look at it) macos instructions for jpackage.

[tobiasdiez]

Sorry, I've overlooked your comment. The 32-bit folder HKEY_LOCAL_MACHINE\Software\Google\Chrome\Extensions works fine on my 64bit machine, and so far nobody complained. I would thus leave it as it is right now.

[LyzardKing]

Ok! I just wanted confirmation that it works, since it shouldn't according to the google website.
I uploaded a branch with the deb part for now.

[LyzardKing]

Just to recap...
I looked at this again, and I cannot figure out if a .app mac program can have a postinstall trigger.
The only idea I have is to add something in jabref itself on the first run..
But it's a bit of a bodge...
Regarding windows support, It's not too clear to me how the file should be formed.. since I can add the key in the registry, but then I'd need to set a named property...

[Siedlerchr]

Here is some info on this topic:
https://docs.oracle.com/en/java/javase/14/jpackage/override-jpackage-resources.html#GUID-62412365-821D-4736-A20D-70F2D47136D8

There is a postinstall script for pgk and for dmg you might need to integrate such thing in the dmg scpt. That is some AppleScript. Someone who's got a a mac could add some lines to copy the files

https://github.com/openjdk/jdk/tree/730d0ecf19779457968bc54d99330c47fdc4730e/src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/resources

[Siedlerchr]

Now we just need it for windows as well. Probably inlcude this in the wix installer scripts.

[LyzardKing]

I'm not expert... in fact not at all...but could a change like this in the JabRef-post-image.wsf work?
contents = contents.replace("</Product>", "<RegistryKey Root=\"HKMU\" Key=\"Software\\Google\\Chrome\\Extensions\" Action=\"createAndRemoveOnUninstall\" ForceCreateOnInstall=\"yes\"><RegistryValue Type=\"string\" Value=\"bifehkofibaamoeaopjglfkddgkijdlh"/><Property Id=\"update_url\" Value=\"https://clients2.google.com/service/update2/crx\" /></RegistryKey></Product>");

@tobiasdiez You might know how it works..

[tobiasdiez]

That looks promising indeed. Not sure when I find the time to try this.

[github-actions]

This issue has been inactive for half a year. Since JabRef is constantly evolving this issue may not be relevant any longer and it will be closed in two weeks if no further activity occurs.

As part of an effort to ensure that the JabRef team is focusing on important and valid issues, we would like to ask if you could update the issue if it still persists. This could be in the following form:

• If there has been a longer discussion, add a short summary of the most important points as a new comment (if not yet existing).
• Provide further steps or information on how to reproduce this issue.
• Upvote the initial post if you like to see it implemented soon. Votes are not the only metric that we use to determine the requests that are implemented, however, they do factor into our decision-making process.
• If all information is provided and still up-to-date, then just add a short comment that the issue is still relevant.

Thank you for your contribution!

[CraftyDH]

Hi, I would like to work on this issue, could I please be assigned it?

[Siedlerchr]

for firefox I stumbled across this https://github.com/web-eid/wix-custom-action-firefox-extension-install
Requires a custom to be built first