Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIS import takes the wrong date and duplicates abstract #6065

Closed
1 task done
crystalfp opened this issue Mar 5, 2020 · 7 comments · Fixed by #6272
Closed
1 task done

RIS import takes the wrong date and duplicates abstract #6065

crystalfp opened this issue Mar 5, 2020 · 7 comments · Fixed by #6272
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. import

Comments

@crystalfp
Copy link

JabRef 4.3.1
Windows 10 10.0 amd64
Java 1.8.0_172

Publication date taken from the wrong field and the abstract is the concatenation of two fields importing a RIS file.

Steps to reproduce the behavior:

  1. Import the following RIS file (from the Neurons journal):
TY  - JOUR
T1  - Grid Cells for Conceptual Spaces?
AU  - Kriegeskorte, Nikolaus
AU  - Storrs, Katherine R.
Y1  - 2016/10/19
PY  - 2016
N1  - doi: 10.1016/j.neuron.2016.10.006
DO  - 10.1016/j.neuron.2016.10.006
T2  - Neuron
JF  - Neuron
SP  - 280
EP  - 284
VL  - 92
IS  - 2
PB  - Elsevier
N2  - ?Grid cells? encode an animal?s location and direction of movement in 2D physical environments via regularly repeating receptive fields. Constantinescu et al. (2016) report the first evidence of grid cells for 2D conceptual spaces. The work has exciting implications for mental representation and shows how detailed neural-coding hypotheses can be tested with bulk population-activity measures.
AB  - ?Grid cells? encode an animal?s location and direction of movement in 2D physical environments via regularly repeating receptive fields. Constantinescu et al. (2016) report the first evidence of grid cells for 2D conceptual spaces. The work has exciting implications for mental representation and shows how detailed neural-coding hypotheses can be tested with bulk population-activity measures.
SN  - 0896-6273
M3  - doi: 10.1016/j.neuron.2016.10.006
UR  - https://doi.org/10.1016/j.neuron.2016.10.006
Y2  - 2020/03/04
ER  - 
  1. The publication date is taken from the Y2 field, not from the correct Y1 field. This has been fixed in 5.0 portable.
  2. The abstract field is the concatenation of the AB and N2 fields.
Log File
Paste an excerpt of your log file here
@Siedlerchr Siedlerchr added good first issue An issue intended for project-newcomers. Varies in difficulty. import labels Mar 5, 2020
@Siedlerchr Siedlerchr added the bug Confirmed bugs or reports that are very likely to be bugs label Mar 5, 2020
@sksonalkothari
Copy link

Hi, I would like to contribute to this issue, I am new in open source development.

@Siedlerchr
Copy link
Member

@sksonalkothari Thanks for your interest and welcome to JabRef!
Please read through the Contribution Guidelines and set up a workspace

For this issue the relevant code is located in the file: src/main/java/rg/jabref/logic/importer/fileformat/RisImporter.java

@sksonalkothari
Copy link

Hi @Siedlerchr, I did as given in guidelines-for-setting-up-a-local-workspace. And I could successfully run the application. But I could not debug through Eclipse. Its giving me error. I even checked the Gitter group chat for this issue, It seems many people had this one.
But yaa, I went and checked the file which u suggested src/main/java/rg/jabref/logic/importer/fileformat/RisImporter.java
Code seems good, it has a dateTags list, which stores all the date tags from highest to lowest priority ("Y1", "PY", "DA", "Y2"). So if we have some date with Y1, it will be seen on the UI. And I confirmed this on UI. We get the Y1 date.
image
image

For the other concern related to Abstract field, code says that abstract is the concatenation of two fields (N2+AB).
else if ("N2".equals(tag) || "AB".equals(tag)) { String oldAb = fields.get(StandardField.ABSTRACT); if (oldAb == null) { fields.put(StandardField.ABSTRACT, value); } else { fields.put(StandardField.ABSTRACT, oldAb + OS.NEWLINE + value); } }
I didn't get the requirement, what needs to be done here.

@Siedlerchr
Copy link
Member

@sksonalkothari Sorry for the delay. It seems the abstract should only be taken from either the field
AB or the fields N2 instead of concatenation.
So if, AB is empty, take N2

@tobiasdiez
Copy link
Member

Thanks to @Gena928 this should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

@crystalfp
Copy link
Author

The abstract problem seems solved.

But

In the new version the biblatex library indicator disappeared and I remember was easier in the 4.x version to set this mode. Should I open another issue for this?

Thanks for your work!
mario

@Siedlerchr
Copy link
Member

@crystalfp That can be changed in Library Properties

koppor pushed a commit that referenced this issue Jun 1, 2022

Unverified

No user is associated with the committer email.
e740261 Merge pull request #6075 from POBrien333/patch-1048
5251887 Update society-of-biblical-literature-fullnote-bibliography.csl
b4938f4 Update society-of-biblical-literature-1st-edition-fullnote-bibliography.csl
b7afaa1 Update Food and Agriculture Organization of the United Nations to comply with 2022 revision (#6072)
5218a45 Update avian-research.csl (#6076)
627ce4a Merge pull request #5983 from tutam/patch-1
08bd306 Re-indent CSL styles
d97aec7 Update suomen-antropologi-journal-of-the-finnish-anthropological-society.csl
00439b1 Re-indent CSL styles
914a4dc Update suomen-antropologi-journal-of-the-finnish-anthropological-society.csl
ef4ecff Re-indent CSL styles
224b1d3 Update society-of-biblical-literature-1st-edition-fullnote-bibliography.csl
3297912 Update society-of-biblical-literature-1st-edition-fullnote-bibliography.csl
156a850 add title-short to all SBL variants
3f6c407 Merge pull request #6071 from denismaier/fixbernsozanthro
a7b3228 Re-indent CSL styles
d624bda removes abstract from issued macro
f3221f4 Update glossa.csl (#6070)
63c0c6d Rework frontiers-in-ecology-and-the-environment.csl (#6067)
7502061 Bump nokogiri from 1.13.5 to 1.13.6 (#6068)
374238f Bump nokogiri from 1.13.4 to 1.13.5 (#6065)
7b09f4f Create journal-of-occupational-and-environmental-medicine.csl (#6053)
9e7a74b Update revista-ladinia.csl (#6058)
13461e5 Update suomen-antropologi-journal-of-the-finnish-anthropological-society.csl
2e86264 Re-indent CSL styles
98ff3de Update suomen-antropologi-journal-of-the-finnish-anthropological-society.csl
bcab5dc Fix timestamp
76aeb4c Create suomen-antropologi-journal-of-the-finnish-anthropological-society.csl

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: e740261
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. import
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants