-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store proxy password and apikeys in native OS credential store #10044
Conversation
No, the pipe char is hardcoded in the java-keyring library. |
Some implementation changes were discussed: |
Co-authored-by: Carl Christian Snethlage <[email protected]>
Was this tested and confirmed using Ubuntu / GNOME? It doesn't work as Keyring.create() repeatedly returns null. I'd say this is OS specific, but do we understand where and when it won't work? When not possible, password saving probably shouldn't be provided as an option (as it's misleading behaviour). Current behaviour is to swallow exceptions, etc... |
follow up to #9652
fixes #9652 (comment)
Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/106
depends on #10004
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)