Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use / instead of | as separation char #88

Open
koppor opened this issue Jun 29, 2023 · 0 comments
Open

Use / instead of | as separation char #88

koppor opened this issue Jun 29, 2023 · 0 comments

Comments

@koppor
Copy link

koppor commented Jun 29, 2023

We successfully included the library in our tool - JabRef/jabref#10044

I checked the output in Windows 10's Credential Manager:

image

I wonder about the `|'

Logitech uses / for separation:

image

Microsoft adds some key-value stuff, but I like the Logitech one better --> is it possible to replace the | with a /?

image

I would like to have / as separator in Windows, too. Looks nicer 😅.

Code:

Boolean success = nativeLibraries.getAdvapi32().CredReadA(service + '|' + account, type, unused, ref);

Did not submit a PR right away, because I don't know about failing test cases. Wanted to note down the feature wish.

When implementing, the code should have backwards compatibility turned on and at reading, it should check first for /, then for |.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant