-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To output or not to output when there's no difference... #52
Comments
I can live with that. I don't know what else I would choose. An idea is to have an option to set that to blank / nothing. |
We can make it return a This way we can do something like: echo $diff->render($renderer);
// Renders the differences or nothing or $rendererOutput = $diff->render($renderer);
echo $rendererOutput === false ? 'No differences found.' : $rendererOutput ;
// Renders the differences or 'No differences found' |
In WackoWiki we check for nodiff in advance and the template engine sets then [ ' _t: NoDifferences ' ].
https://github.com/WackoWiki/wackowiki/blob/master/wacko/handler/page/diff.php#L330 |
This is not advised... It's also possible the visibility of this method might changes in the future. We can add another method to the Edit: |
- Fixed calling Diff::getGroupedOpCodes() twice.
HTML Side by Side Diff, HTML Inline Diff and HTML Unified Diff will produce output string
No differences found.
It's hard-coded in theHtmlArray
class.@JBlond Let me know if, and into what, you want this to be changed.
Originally posted by @DigiLive in #50 (comment)
The text was updated successfully, but these errors were encountered: